Closed ramonwirsch closed 1 year ago
Merging #43 into master will increase coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #43 +/- ##
============================================
+ Coverage 87.73% 87.75% +0.02%
- Complexity 0 150 +150
============================================
Files 23 23
Lines 432 433 +1
Branches 39 28 -11
============================================
+ Hits 379 380 +1
Misses 49 49
Partials 4 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f001e5f...ca61469. Read the comment docs.
@ramonwirsch I know it's been 6 years since you proposed the changes, are you still interested in this?
Uh, I did not even remember I had this open. No, I am no longer on the project that used the javacc plugin, so I personally do not care anymore.
Basically declared the tasks as
@CacheableTask
.Additionally, added programArgs as input property and declared 'source' property as relative
The gradle version was upgraded to 4.0.2. Acceptance tests were modified so that they work for gradle 3.3 up to 4.1-rc1. The simple test cases for jjdoc, jjtree, javacc were replicated to run against gradle 3.3 guaranteeing backwards compatibility even though a newer gradle version is used for building.
This is the Pull-request announced in #42