javacc / javaccPlugin

A JavaCC plugin for Gradle
MIT License
33 stars 16 forks source link

Gradle build cache support for all tasks #43

Closed ramonwirsch closed 1 year ago

ramonwirsch commented 7 years ago

Basically declared the tasks as @CacheableTask.

Additionally, added programArgs as input property and declared 'source' property as relative

The gradle version was upgraded to 4.0.2. Acceptance tests were modified so that they work for gradle 3.3 up to 4.1-rc1. The simple test cases for jjdoc, jjtree, javacc were replicated to run against gradle 3.3 guaranteeing backwards compatibility even though a newer gradle version is used for building.

This is the Pull-request announced in #42

codecov-io commented 7 years ago

Codecov Report

Merging #43 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     87.73%   87.75%   +0.02%     
- Complexity        0      150     +150     
============================================
  Files            23       23              
  Lines           432      433       +1     
  Branches         39       28      -11     
============================================
+ Hits            379      380       +1     
  Misses           49       49              
  Partials          4        4
Impacted Files Coverage Δ Complexity Δ
.../javacc/compilationresults/CompiledJavaccFile.java
.../javacc/programexecution/JavaccProgramInvoker.java
...avacc/programexecution/AbstractProgramInvoker.java
...s/javacc/programexecution/JjdocProgramInvoker.java
...s/javacc/programexecution/JjdocExecutorAction.java
...inc/gradle/plugins/javacc/JavaccTaskException.java
...ns/javacc/compiler/NonJavaccSourceFileVisitor.java
...gins/javacc/programexecution/ProgramArguments.java
...ca/coglinc/gradle/plugins/javacc/JavaccPlugin.java
.../javacc/programexecution/JjtreeProgramInvoker.java
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f001e5f...ca61469. Read the comment docs.

zbynek commented 1 year ago

@ramonwirsch I know it's been 6 years since you proposed the changes, are you still interested in this?

ramonwirsch commented 1 year ago

Uh, I did not even remember I had this open. No, I am no longer on the project that used the javacc plugin, so I personally do not care anymore.