Closed kpitt closed 3 years ago
Merging #55 (b105970) into master (7d01116) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage 87.73% 87.73%
Complexity 149 149
=========================================
Files 23 23
Lines 432 432
Branches 28 28
=========================================
Hits 379 379
Misses 49 49
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
...avacc/plugin/gradle/javacc/AbstractJavaccTask.java | 68.18% <ø> (ø) |
|
...javacc/plugin/gradle/javacc/CompileJavaccTask.java | 23.52% <ø> (ø) |
|
.../javacc/plugin/gradle/javacc/CompileJjdocTask.java | 25.00% <ø> (ø) |
|
...javacc/plugin/gradle/javacc/CompileJjtreeTask.java | 23.52% <ø> (ø) |
|
...in/gradle/javacc/JavaToJavaccDependencyAction.java | 100.00% <ø> (ø) |
|
.../org/javacc/plugin/gradle/javacc/JavaccPlugin.java | 93.93% <ø> (ø) |
|
...vacc/plugin/gradle/javacc/JavaccTaskException.java | 100.00% <ø> (ø) |
|
.../javacc/compilationresults/CompiledJavaccFile.java | 92.06% <ø> (ø) |
|
...nresults/CompiledJavaccFileOperationException.java | 100.00% <ø> (ø) |
|
...mpilationresults/CompiledJavaccFilesDirectory.java | 100.00% <ø> (ø) |
|
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7d01116...b105970. Read the comment docs.
@kpitt why is the new plugin ID so long? Most other plugins do not have gradle
or plugin
in their IDs. It might be enough to have something like org.javacc.javacc
(or possibly different plugins org.javacc.java
and org.javacc.cpp
for the different target languages?)
This changes the plugin ids and namespaces of the JavaCC Gradle plugin to match the JavaCC organization. The ids used are as follows:
Gradle Plugin Portal:
org.javacc.plugin.javacc-gradle
Maven:
org.javacc.plugin
javacc-gradle-plugin
Java Package Root:
org.javacc.plugin.gradle.javacc
Resolves #52
Note that the Gradle plugin id does not fully spell out
javacc-gradle-plugin
in the last component as originally planned. The Gradle plugin id is a single, fully-quallified value that always includes the namespace, andplugin
already appears in the namespace (not to mention that the Gradle Plugin Portal doesn't host anything but Gradle plugins), so repeating-plugin
again just seemed redundant.This PR also incorporates all of the README changes from PR #54, so that PR should be closed if this one is accepted.