search

javacc / javaccPlugin

A JavaCC plugin for Gradle
MIT License
33 stars 16 forks source link

Change plugin ids to match JavaCC organization conventions #55

Closed kpitt closed 3 years ago

kpitt commented 3 years ago

This changes the plugin ids and namespaces of the JavaCC Gradle plugin to match the JavaCC organization. The ids used are as follows:

Gradle Plugin Portal:

Maven:

Java Package Root: org.javacc.plugin.gradle.javacc

Resolves #52

Note that the Gradle plugin id does not fully spell out javacc-gradle-plugin in the last component as originally planned. The Gradle plugin id is a single, fully-quallified value that always includes the namespace, and plugin already appears in the namespace (not to mention that the Gradle Plugin Portal doesn't host anything but Gradle plugins), so repeating -plugin again just seemed redundant.

This PR also incorporates all of the README changes from PR #54, so that PR should be closed if this one is accepted.

codecov-commenter commented 3 years ago

Codecov Report

Merging #55 (b105970) into master (7d01116) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     87.73%   87.73%           
  Complexity      149      149           
=========================================
  Files            23       23           
  Lines           432      432           
  Branches         28       28           
=========================================
  Hits            379      379           
  Misses           49       49           
  Partials          4        4
Impacted Files Coverage Δ
...avacc/plugin/gradle/javacc/AbstractJavaccTask.java 68.18% <ø> (ø)
...javacc/plugin/gradle/javacc/CompileJavaccTask.java 23.52% <ø> (ø)
.../javacc/plugin/gradle/javacc/CompileJjdocTask.java 25.00% <ø> (ø)
...javacc/plugin/gradle/javacc/CompileJjtreeTask.java 23.52% <ø> (ø)
...in/gradle/javacc/JavaToJavaccDependencyAction.java 100.00% <ø> (ø)
.../org/javacc/plugin/gradle/javacc/JavaccPlugin.java 93.93% <ø> (ø)
...vacc/plugin/gradle/javacc/JavaccTaskException.java 100.00% <ø> (ø)
.../javacc/compilationresults/CompiledJavaccFile.java 92.06% <ø> (ø)
...nresults/CompiledJavaccFileOperationException.java 100.00% <ø> (ø)
...mpilationresults/CompiledJavaccFilesDirectory.java 100.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d01116...b105970. Read the comment docs.

zbynek commented 1 year ago

@kpitt why is the new plugin ID so long? Most other plugins do not have gradle or plugin in their IDs. It might be enough to have something like org.javacc.javacc (or possibly different plugins org.javacc.java and org.javacc.cpp for the different target languages?)