Closed zbynek closed 1 year ago
Base: 87.73% // Head: 87.90% // Increases project coverage by +0.17%
:tada:
Coverage data is based on head (
e99746c
) compared to base (59cd9f7
). Patch coverage: 91.66% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@johnmartel I've been granted push access to this repo but I think it would be better if I only push changes seen/reviewed by another person. Will you have time to check this PR?
@zbynek I just had a look, sorry for the delay. This looks good to me. When I handed over the repository, I was well aware that the plugin needed a lot of upgrading in terms of supported Gradle versions, Javacc dependency and Java code in general. Thanks for making a step towards levelling up the codebase.
I am unfortunately not available for much involvement in this plugin's development, but I'm glad to see it lives :)
Same idea as https://github.com/javacc/javaccPlugin/pull/48 , but using Java8 syntax