search

javadelight / delight-fileupload

A simple wrapper for Apache Commons FileUpload to use it with Netty and other IO servers
Other
10 stars 3 forks source link

Missing javax.servlet package #10

Open MikeWarren2014 opened 1 year ago

MikeWarren2014 commented 1 year ago

That package is present in this repository. However, the version that I installed from Maven Central does NOT have that package.

image

You may be able to fix this issue by releasing new version...

MikeWarren2014 commented 1 year ago

UPDATE: bringing in the dependency as

implementation 'javax.servlet:javax.servlet-api:3.1.0'

in Gradle fixed the issue, at least as far as my IDE is concerned....

mxro commented 1 year ago

Thank you for raising this issue!

This is the intended behaviour - not specifying the javax.servlet version in the dependencies of this package allows to use it with any version in the host application.

Thus, the dependency is supplied as provided: https://github.com/javadelight/delight-fileupload/blob/master/pom.xml#L36

I've added a comment to the Readme: https://github.com/javadelight/delight-fileupload/blob/master/README.md#dependency

Do you think that could be helpful to avoid this problem for others?