Fix stopping of service

javadiscord / java-discord-api

A wrapper over the discord API to create bots using Java

GNU General Public License v3.0

7 stars 8 forks source link

Closed surajkumar closed 1 month ago

surajkumar commented 1 month ago

The stop functionality introduced in #115 did not work correctly. During testing:

it was not killing the gateway, the bot was still receiving and handling events
the executor was failing to shutdown and there were loads of threads still running in the background
the retry logic we have was re-initalizing the connection when the socket was disconnected

This PR implements the stop functionality properly and ensures all threads that were created have been killed.

surajkumar commented 1 month ago

cc @mennafabio - you might find this interesting.

sonarcloud[bot] commented 1 month ago