search

javadr / negar-gui

Graphical User Interface for Negar -- Persian Text Editor
GNU General Public License v3.0
13 stars 2 forks source link

Add logo_small and its logic to be used in windows os. #3

Closed ALiwoto closed 1 year ago

ALiwoto commented 1 year ago

This pull request fixes the issue with icon file not being set as window icon on windows platform while using PyInstaller tool to get executable output from it. Also add launch.json for a better debug experience on vscode.

ALiwoto commented 1 year ago

@javadr there is just one thing, have you tested PyInstaller on linux and the icon thingy? If yes, I can also push gh workflows; if you are not sure, I can test it either on my WSL or my VM. Current logic at constants.py is that if the platform is windows, it will set the icon to the small version of the file, otherwise it will be the same old file (for linux or macos for example).

javadr commented 1 year ago

Thanks, @ALiwoto. 1- There was an issue with the logo in Linux, so I reverted that part to the old version. 2- I've not tested the PyInstaller yet.

javadr commented 1 year ago

It would be nice if you could test it on your VM.