Test for programmatic-registration module is incorrect

javaee-samples / javaee7-samples

Java EE 7 Samples

Other

2.51k stars 1.66k forks source link

Open orelgenya opened 9 years ago

orelgenya commented 9 years ago

This test wrong at many points:

test returns before calling ParentServlet, which is responsible for ChildServlet registration;
webclient calls wrong URLs (/ is redundant and don't match with mappings);
mapping for ChildServlet isn't set (dynamically)
fail(..) statement prevents execution of meaningful part of the test;
and finally it wouldn't work because programmatic registration is impossible after ServletContext initialization is finished.

arun-gupta commented 9 years ago

Send a PR with the fix?