JPA test for aggregate functions in select clause

arjantijms commented 8 years ago

Tested on GlassFish, WildFly, Liberty and WebLogic

Fails on GlassFish, WildFly and Liberty for various reasons:

GlassFish: bug regarding combination between data-source, pu and embedded JDBC
WildFly: Hibernate bug with the actual aggregate function in select
Liberty: spec issue with ability to load JDBC driver from WEB-INF/lib

Tested Liberty with alternative version using Liberty proprietary data source and test passed then.

bartoszmajsak commented 8 years ago

Just wondering what is the point of the PR if you merge it on your own? :)

arjantijms commented 8 years ago

Well, to be able to develop in a fork and test it first on different platforms, without disturbing the main project yet.

Then when the new test seems reasonably okay, I do the PR, so it kicks of the CI job. That CI job ensures that everything compiles and I didn't accidentally dependent on something that's on any of my test platforms.

Finally, I don't merge right away after the CI job finishes, but let the PR sit there for some 12 hours or so, so people can provide feedback if needed. If there's no feedback after that time I merge it in.

So, multiple reasons ;)

javaee-samples / javaee7-samples

JPA test for aggregate functions in select clause #333