search

javaee-samples / javaee7-samples

Java EE 7 Samples
https://travis-ci.org/javaee-samples/javaee7-samples
Other
2.51k stars 1.66k forks source link

Update versions in main pom.xml and do some cleaning #364

Closed arjantijms closed 7 years ago

arjantijms commented 7 years ago

The main pom.xml has quite a number of older versions in it. Arquillian, the core Maven plug-ins, and especially the JBoss/WildFly containers are at rather old versions.

JBoss/WildFly specifically also still uses the old Arquillian group id where the version was coupled to the server (in later versions these moved to a new namespace with decoupled version numbers). JBoss/WildFly also have a number of client dependencies that would need matching version updates.

Furthermore there's an old EAP 7.2 (Java EE 6) profile that doesn't really work and is quite outdated.

As for cleaning, the main pom could do with a small amount of re-ordering, and some comments to make it a little less unwieldy.

I'm also not entirely sure if the drone/graphene dependencies should stay in, as AngularJs is the sole test that really uses it. There's also a lone Facelets test using it, but I'm not sure if it's really needed there. I'm not really sure what's the cause, but I often see errors when running the Drone based test (some class can't be found), basically the same issues as listed here: https://github.com/cilf/arquillian-java-ee-7-primefaces-5

There's also a bunch of profiles for browsers, but I wonder if they are actually used. They look like a copy/paste of the Arquillian guide (http://arquillian.org/guides/functional_testing_using_graphene/) but without the necessary entry in arquillian.xml. Do they actually work somehow in an other way? Can someone confirm?

arjantijms commented 7 years ago

Most stuff has been done in the mean time.