search

javaee-samples / javaee7-samples

Java EE 7 Samples
https://travis-ci.org/javaee-samples/javaee7-samples
Other
2.51k stars 1.66k forks source link

Fix some failures using wildfly-swarm profile #424

Closed juangon closed 6 years ago

juangon commented 6 years ago

-->by upgrading upgrading arquillian and wildfly swarm version. Additionally, cut the dependency from test-utils to parent to avoid unwanted added dependencies

Here we go @arjantijms !

Thanks a lot!

arjantijms commented 6 years ago

Thanks! Looks great. I'll wait for travis to clear before merging, but looks okay!

juangon commented 6 years ago

Great. Your solution looks much better than mine and is the actual fix for the actual error. Thanks!

juangon commented 6 years ago

Oopps it fails as it tries to compile the project alone first. I think we unfortunately need to declare that variable in the test-utils project. Duplicate variable but will work...

juangon commented 6 years ago

Will update branch on Monday.

juangon commented 6 years ago

Can't believe, 5 hours to execute these tests and 3 still left :-0

juangon commented 6 years ago

@arjantijms ready to go!

arjantijms commented 6 years ago

Can't believe, 5 hours to execute these tests and 3 still left :-0

It's indeed quite slow. I guess it's due to Travis being a free service and doesn't give you much cycles.

arjantijms commented 6 years ago

@arjantijms ready to go!

\o/

juangon commented 6 years ago

Thanks very much @arjantijms !