search

javaee-samples / javaee7-samples

Java EE 7 Samples
https://travis-ci.org/javaee-samples/javaee7-samples
Other
2.51k stars 1.66k forks source link

Removing default activation of payara-ci-managed profile #426

Closed jkopriva closed 6 years ago

jkopriva commented 6 years ago

Profile payara-ci-managed was activated by default, so during build payara41 was extracted to every target folder.

jkopriva commented 6 years ago

@arjantijms Hi, can you please review?

arjantijms commented 6 years ago

Removing the default CI target means the tests won't run by, well, default. A better solution which I thought I had already applied, is to always unpack in the same (parent) folder. It should be this one:

<outputDirectory>${session.executionRootDirectory}/target</outputDirectory>

If that broke somehow (I'll check soon) a better direction would be to restore that.

jkopriva commented 6 years ago

@arjantijms thanks for pointing out, it looks like your solution is working. I have had probably some different version of repo.