javaee-samples / javaee7-samples

Java EE 7 Samples
https://travis-ci.org/javaee-samples/javaee7-samples
Other
2.5k stars 1.66k forks source link

fix the test for HTTP protocol upgrade #461

Closed Ladicek closed 4 years ago

Ladicek commented 4 years ago

If the HTTP client wants to request protocol upgrade, it must send the Upgrade header. It should also set the Connection header. This test didn't do that, so conforming implementations could reject the request.upgrade() call. The fix is simple: add the 2 headers on the client side (i.e., in the test).

To be able to set Connection and Upgrade headers on the java.net.HttpURLConnection, restricted headers must be allowed by setting a special system property.

See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Protocol_upgrade_mechanism and the Servlet specification 4.0, section 2.3.3.5.

arjantijms commented 4 years ago

Nice!