javaee-samples / javaee8-samples

Java EE 8 Samples
Other
376 stars 238 forks source link

Fixed #23 ClientConfig differs between appservers #24

Closed dmatej closed 6 years ago

dmatej commented 6 years ago
arjantijms commented 6 years ago

Looks good too. Small remark is that the final modifiers and this prefixes are mostly not really needed, but alas, it's a small thing ;)

dmatej commented 6 years ago

It depends, I often do some big refactorings in very ugly code and then they are helpful for readibility and even to avoid unwanted collisions. But I will respect rules in this repo next time (I see many "fightings" of tabs vs. spaces here too) ;)

arjantijms commented 6 years ago

Thanks! It's probably not "fightings", just mistakes ;) The rule should be spaces for this repo.