search

javaee-samples / javaee8-samples

Java EE 8 Samples
Other
376 stars 238 forks source link

Fix servlet/http2 when using latest Oracle JDK versions #36

Closed juangon closed 5 years ago

juangon commented 5 years ago

Hi @arjantijms . We detected this issue thanks to our test matrix and affected Payara too. Thanks!

juangon commented 5 years ago

It seems when using Oracle, default jdk 1.8 isn't detected

Ladicek commented 5 years ago

This is really weird. Perhaps add profiles for the other versions of Oracle JDK 8 between 1.8.0_152 and 1.8.0_201, per https://github.com/jetty-project/jetty-alpn/blob/master/docs/version_mapping.properties?

juangon commented 5 years ago

@Ladicek I added them in order to be consistent. Thanks for suggestion

Ladicek commented 5 years ago

@juangon I don't think what you added is correct. JDKs from 1.8.0_161 to 1.8.0_181 use 8.1.12.v20180117, per the file I linked above.

juangon commented 5 years ago

@Ladicek thanks a lot. I took a brief look and thought they were all the same numbers. Thankfully I am not an accountant :-)

Ladicek commented 5 years ago

Great, thanks :-) LGTM now.

arjantijms commented 5 years ago

Cool, thx again!