Local and Remote annotation javadoc do not reflect relaxed calculation rules

[glassfishrobot]

The javadoc still says "is only required when the bean class does not implement only a single interface"

Affected Versions

[3.2]

[glassfishrobot]

Reported by mvatkina

[glassfishrobot]

mvatkina said: Proposed changes for @Local:

Use of the Local annotation is required when the bean class exposes one or more local business interface and any of the following is true:

• the bean class does not implement its business interfaces
• the bean exposes a no-interface view
• the bean class implements more than one interface and at least one of the interfaces is explicitly designated as a business interface by using the Local or Remote annotation on the interface, or in the deployment descriptor

The following interfaces are excluded when determining whether the bean class has business interfaces: java.io.Serializable; java.io.Externalizable; any of the interfaces defined in javax.ejb.

[glassfishrobot]

mvatkina said: The new text for the Local.value:

Specifies the local business interface(s) of the bean. The value element is specified only when the annotation is applied to the bean class. It is required to be specified if any of the following is true:

• the bean class does not implement its local business interface
• any of the implemented interfaces is designated as a remote interface
• some of the implemented interfaces are designated as local business interfaces using Local annotation on the interface, while others (excluding java.io.Serializable, java.io.Externalizable, and any of the interfaces defined by the javax.ejb package) are not designated as such.

The new text for the Remote.value:

Specifies the remote business interface(s) of the bean. The value element is specified only when the annotation is applied to the bean class. It is required to be specified if any of the following is true:

• the bean class does not implement its remote business interface
• any of the implemented interfaces is designated as a local interface
• some of the implemented interfaces are designated as local business interfaces using Remote annotation on the interface, while others (excluding java.io.Serializable, java.io.Externalizable, and any of the interfaces defined by the javax.ejb package) are not designated as such.

[glassfishrobot]

mvatkina said: Marking it fixed (see rev 58234). Please reopen if any further changes are required.

[glassfishrobot]

jlmonteiro said: Marina,

sorry for the late feedback.

Specifies the local business interface(s) of the bean. The value element is specified only when the annotation is applied to the bean class. It is required to be specified if any of the following is true:

I would keep the "only" as it was before. --> "It is only required".

• the bean class does not implement its local business interface

If the bean class does not explicitly implement the interface, it can not be used through its business interface. Did I miss sthg? It refers to the following in the current spec doc "Note that while it is expected that the bean class will typically implem ent its business interface(s), if the bean class uses annotations or the deployment descriptor to designate its business interface(s), it is not required that the bean class also be specified as implementing the interface(s)."

But dunno when it makes sense.

• any of the implemented interfaces is designated as a remote interface

"At least one of" instead of "any of" ?

• some of the implemented interfaces are designated as local business interfaces using Local annotation on the interface, while others (excluding java.io.Serializable, java.io.Externalizable, and any of the interfaces defined by the javax.ejb package) are not designated as such.

The previous phrasing was not that bad for me

[glassfishrobot]

mvatkina said: Which previous was not bad? The 3.1 version, or the text I proposed in my 1st comment?

[glassfishrobot]

mvatkina said: The new text (similar for Remote):

Specifies the local business interface(s) of the bean. The value element is specified only when the annotation is applied to the bean class. It is only required to be specified if any of the following is true:

• the bean class does not implement its local business interface
• at least one of the implemented interfaces is designated as a remote interface
• the bean class implements two or more interfaces and at least one of the implemented interfaces is designated as local business interfaces using Local annotation on the interface, and at least one other interface (excluding java.io.Serializable, java.io.Externalizable, and any of the interfaces defined by the javax.ejb package) has no designation.

[glassfishrobot]

jlmonteiro said: Thanks Marina, yes it sounds better for me. Dunno for others.

[glassfishrobot]

mvatkina said: Thanks Jean-Louis. As others had never objected, I'm closing this issue.

[glassfishrobot]

Was assigned to mvatkina

[glassfishrobot]

This issue was imported from java.net JIRA EJB_SPEC-81

[glassfishrobot]

Marked as fixed on Friday, March 1st 2013, 12:22:03 pm