search

javaee / glassfish-maven-plugin-legacy

Other
1 stars 5 forks source link

presence of asadmin shell script file prevents asadmin.bat execution in AsadminCommand #14

Open glassfishrobot opened 11 years ago

glassfishrobot commented 11 years ago

Glassfish 3.1.2 installation on windows will place both asadmin and asadmin.bat in the bin folder for glassfish. The detection logic in AsadminCommand is slightly broken:

81 if (!asadmin.exists() && System.getProperty("os.name").contains("indows"))

{ 82 asadmin = new File(binDir, "asadmin.bat"); 83 }

asadmin shell script will be found, and regardless of the operating system being windows, the wrong file will be executed. the check for the presence of asadmin is not required, I think, and simply the check for windows should be sufficient to run the .bat command instead.

Environment

Windows

Affected Versions

[current]

glassfishrobot commented 11 years ago

Reported by mgabrielm2

glassfishrobot commented 7 years ago

This issue was imported from java.net JIRA MAVEN_GLASSFISH_PLUGIN-14