search

javaee / glassfish-maven-plugin-legacy

Other
1 stars 5 forks source link

Plugin should use asadmin.bat on Windows platforms by default #5

Closed glassfishrobot closed 13 years ago

glassfishrobot commented 13 years ago

Currently the plugin tries to execute asadmin with no extension. If not found and OS Platworm is windows, then it tries asadmin.bat. As a result, the plugin does not work with default installation on Windows without deleting asadmin first.

Attached patch reverses the behaviour - asadmin.bat is used by default on Windows platforms, and than falls back to asadmin.

Affected Versions

[current]

glassfishrobot commented 13 years ago

Reported by pdudits

glassfishrobot commented 13 years ago

msreekanth said: This is not an improvement.Clearly it is a bug that needs to be fixed for windows users. Since glassfish installation comes with both asadmin and asadmin.bat, execution will never enter into if condition below and always asadmin file meant for linux will be used.

File asadmin = new File(binDir, "asadmin"); if (!asadmin.exists() && System.getProperty("os.name").contains("indows"))

{ asadmin = new File(binDir, "asadmin.bat"); }

Again in glassfish v2,if applicable, may work since it only comes with one variant of asadmin file .Need to check it if needed.

glassfishrobot commented 13 years ago

arungupta said: Adding to the CC list.

Byron is working on a fix.

glassfishrobot commented 13 years ago

bnevins said: Fixed in svn revision#84

Fix is as in patch. Now it checks if we are running on Windows. If so – it uses asadmin.bat in preference to asadmin

glassfishrobot commented 12 years ago

liwei13705 said: Can you please install this patched version to Java.net Maven2 Repository? The current one there is outdated. http://download.java.net/maven/2/org/glassfish/maven/plugin/maven-glassfish-plugin/

glassfishrobot commented 11 years ago

bkravandi said: Sorry I'm new to java, how can I apply this patch ?

glassfishrobot commented 8 years ago

kingoleg said: Hi,

Would you like to release a new version of plugin with this and others fixes? Or it's dead?

Regards, Oleg

glassfishrobot commented 13 years ago

File: maven-glassfish-plugin_5.patch Attached By: pdudits

glassfishrobot commented 13 years ago

Was assigned to bnevins

glassfishrobot commented 7 years ago

This issue was imported from java.net JIRA MAVEN_GLASSFISH_PLUGIN-5

glassfishrobot commented 13 years ago

Marked as fixed on Tuesday, September 13th 2011, 2:18:19 pm