search

javaee / grizzly

Writing scalable server applications in the Java™ programming language has always been difficult. Before the advent of the Java New I/O API (NIO), thread management issues made it impossible for a server to scale to thousands of users. The Grizzly NIO framework has been designed to help developers to take advantage of the Java™ NIO API.
https://javaee.github.io/grizzly/
Other
222 stars 60 forks source link

Fix for 1833 introduced a regression with expect-continue processing. #1844

Closed glassfishrobot closed 8 years ago

glassfishrobot commented 8 years ago

Hi, Ryan. I've been running some tests with 2.3.36-SNAPSHOT because of another issue (https://github.com/AsyncHttpClient/async-http-client/issues/1209) and found our tests for the expect-continue case start failing with the upgrade. By reverting the commit for this fix the tests go green again so I think the fix might have introduced a regression. If you still have the Mule code at hand, one of the failing test is org.mule.module.http.functional.listener.HttpListenerExpectHeaderStreamingNeverTestCase#http11WithExpectHeader (sends an expect continue request, waits for a response and then sends another regular request, which hangs with these changes). I'll try to reproduce it on one of your tests but it would be very helpful if you could take a look. Let me know if there's anything else I can do to help. Thanks

Affected Versions

[2.3.25, 3.0]

glassfishrobot commented 8 years ago

Reported by @rlubke

glassfishrobot commented 8 years ago

@rlubke said: So far I haven't been able to reproduce this in the Grizzly test suite trying to mimic the content sent by the Mule tests.

Will continue to investigate. If you can create a test case from a Grizzly test as you thought you might be able to, that would save some time.

Thanks!

glassfishrobot commented 8 years ago

@rlubke said: Changes applied.

master: 63f427da039dff114ed7d17597156e8d61b4b1db 2.3.x: e49f67e9868bc5858e8459a34d1eae0d11cec940

glassfishrobot commented 8 years ago

afelisatti said: Hi, Ryan. I've verified 2.3.26-SNAPSHOT against both AHC and mule and all tests are green now. Any ETA for the release of 2.3.26? Thanks.

glassfishrobot commented 8 years ago

@rlubke said: I'll see if I can take care of it by the end of the week. There's one other issue I'm currently investigating. I'd like to get it in if possible.

glassfishrobot commented 8 years ago

afelisatti said: Hi, Ryan. Any update on the release? Thanks

glassfishrobot commented 8 years ago

@rlubke said: I was out Friday (unexpected) and am still in progress with the other issue. I hope to have it wrapped up today with the release happening this week.

glassfishrobot commented 8 years ago

Issue-Links: is related to GRIZZLY-1833

glassfishrobot commented 7 years ago

This issue was imported from java.net JIRA GRIZZLY-1844

glassfishrobot commented 8 years ago

Marked as fixed on Friday, July 15th 2016, 3:54:24 pm