Closed jmaasing closed 6 years ago
@jmaasing We'll need a signed OCA for contributions [1]. Once done, it should cover you for all of EE.
[1] https://github.com/javaee/grizzly/blob/master/CONTRIBUTING.md
Oh yeah, I'll try to fix that asap. Will comment here when I've submitted it.
@rlubke @jmaasing 's OCA has been reviewed and approved! 👍
This PR has test fixes for two things.
The negativeFileTransferTest can fail in a very edgy-case where the test is run in docker and the file system is a separate docker volume. Apparently the file.setReadable(false) returns true even though the file is still readable. So just add a check too see if the file is still readable and if so skip the test. I also added some more information on the test asserts to make it more visible exactly what assert failed.
TheApache log format test fails if the Locale is not US (or english speaking at least) since the abbreviated month names are used and those a localized. So the tests sets the local before checking the output of the log formatter. I also switch the 'expected' value with the 'actual' value to the correct positions in the assert statement.