search

javaee / grizzly

Writing scalable server applications in the Java™ programming language has always been difficult. Before the advent of the Java New I/O API (NIO), thread management issues made it impossible for a server to scale to thousands of users. The Grizzly NIO framework has been designed to help developers to take advantage of the Java™ NIO API.
https://javaee.github.io/grizzly/
Other
222 stars 60 forks source link

Avoid calling close listeners when list is locked to avoid deadlocks #1984

Closed andrelanka closed 6 years ago

andrelanka commented 6 years ago

See https://github.com/javaee/grizzly/issues/1983 for description of the problem

rlubke commented 6 years ago

Before any pull request can be accepted, the Oracle OCA must be signed and submitted. See: https://github.com/javaee/grizzly/blob/master/CONTRIBUTING.md

andrelanka commented 6 years ago

I sent the OCA to the oracle-ca_us [at] oracle [dot] com a week ago. Is there anything more to do?

carryel commented 6 years ago

@andrelanka I made another PR(https://github.com/javaee/grizzly/pull/1989) using concurrent collection without synchronized block. Before #1962 original code used ConcurrentLinkedQueue. What do you think about https://github.com/javaee/grizzly/pull/1989?

andrelanka commented 6 years ago

@carryel I also had CopyOnWriteArrayList in my mind, but I see some potential issues. I explained it in detail in the comment to you commit.

rlubke commented 6 years ago

I'm checking on the status of the OCA. Will follow up as soon as I have confirmation.