javaee / javahelp

javahelp
Other
14 stars 15 forks source link

Having a double quote (escaped) in the tocitem/@text attribute breaks TOC panel loading in the Help Panel #43

Open glassfishrobot opened 8 years ago

glassfishrobot commented 8 years ago

Version is 2.0_02.

When having a title that ends in a double quote, then the TOC is not loaded, because of:

Parsing failed for jar:file:/D:/programs/Oxygen%20XML%20Editor%2018/lib/editorHelp.jar!/toc.xml
<tocitem text="When Started, Windows Service Reports "Error 1067: Process Terminated Unexpectedly""
           target="windows-service-reports-error-1067"/>
Exception in thread "Thread-3" java.lang.NullPointerException
        at javax.help.MergeHelpUtilities.mergeNodeChildren(MergeHelpUtilities.java:81)
        at javax.help.plaf.basic.BasicTOCNavigatorUI.loadData(BasicTOCNavigatorUI.java:208)
        at javax.help.plaf.basic.BasicTOCNavigatorUI.access$000(BasicTOCNavigatorUI.java:65)
        at javax.help.plaf.basic.BasicTOCNavigatorUI$NavSwingWorker.construct(BasicTOCNavigatorUI.java:252)
        at com.sun.java.help.impl.SwingWorker$2.run(SwingWorker.java:129)
        at java.lang.Thread.run(Unknown Source)

The toc.xml file is wellformed and has the content:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE toc
  PUBLIC "-//Sun Microsystems Inc.//DTD JavaHelp TOC Version 1.0//EN" "http://java.sun.com/products/javahelp/toc_1_0.dtd"> <toc version="2.0">
   <tocitem text="Test">
      <tocitem text="When Started, Windows Service Reports &#34;Error 1067: Process Terminated Unexpectedly&#34;"
               target="service">
         ...
      </tocitem>
   </tocitem>
</toc>
glassfishrobot commented 8 years ago

Reported by dan_caprioara

glassfishrobot commented 8 years ago

Was assigned to brinkley

glassfishrobot commented 7 years ago

This issue was imported from java.net JIRA JAVAHELP-43