Improve collection-setter-injector plugin to eagerly initialize collection properties

[glassfishrobot]

If the List implementation is the default java.util.ArrayList, it will be lazily initialized. This can cause a problem when using the EqualsBuilder.reflectionEquals(obj, obj) method, as implemented by commons-lang-plugin, if the expected object holds a null for a collection property while the actual object holds an empty ArrayList simply because the getter method has been called, which has a side effect. Note that the lazy initialization is implemented for performance reason.

Environment

Operating System: All Platform: All

Affected Versions

[current]

[glassfishrobot]

Reported by ozgwei

[glassfishrobot]

ozgwei said: Created an attachment (id=5) eager initializing collection properties

[glassfishrobot]

ozgwei said: Attached is a patch to allow users to optionally specifies whether eager initialization of list properties are preferred.

Alex

[glassfishrobot]

ozgwei said: Created an attachment (id=6) a newer patch with null check in setter method, overwriting the previous submitted patch

[glassfishrobot]

ozgwei said: When user specifies the option of eager initialization, the collection setter methods generated will also check whether the parameter is null or not. If the parameter is null, a newly created ArrayList will be assigned to the collection property.

[glassfishrobot]

lexi said: The plugin was not ported after cvs->svn move, dead at the moment.

[glassfishrobot]

File: collection-setter-injector-patch-20081015-1641.txt Attached By: ozgwei

[glassfishrobot]

File: collection-setter-injector-patch.txt Attached By: ozgwei

[glassfishrobot]

Was assigned to lexi

[glassfishrobot]

This issue was imported from java.net JIRA JAXB2_COMMONS-13