bundles/jaxws-rt depends on the reactor ordering

[glassfishrobot]

bundles/jaxws-rt is a pom project that produces an assembly with module references:

<moduleSets>
        <moduleSet>
            <binaries>
<unpack>true</unpack>
<outputDirectory>/</outputDirectory>
<includeDependencies>false</includeDependencies>
            </binaries>
        </moduleSet>
    </moduleSets>

While this works in a single build, when put as part of a big maven reactor, the ordering seems not guaranteed. Looking closer at the big reactor, the submodules are not built before the parent, resulting in a build failure.

Straighforward fix is to declare the modules also as dependencies:

index f8fc48d..abb7feb 100644
--- bundles/jaxws-rt/pom.xml
+++ bundles/jaxws-rt/pom.xml
@@ -66,6 +66,36 @@
             <groupId>javax.xml.ws</groupId>
             <artifactId>jaxws-api</artifactId>
         </dependency>
+       <dependency>
+           <groupId>com.sun.xml.ws</groupId>
+           <artifactId>rt</artifactId>
+           <version>${project.version}</version>
+           <optional>true</optional>
+       </dependency>
+       <dependency>
+           <groupId>com.sun.xml.ws</groupId>
+           <artifactId>rt-fi</artifactId>
+           <version>${project.version}</version>
+           <optional>true</optional>
+       </dependency>
+       <dependency>
+           <groupId>com.sun.xml.ws</groupId>
+           <artifactId>rt-ha</artifactId>
+           <version>${project.version}</version>
+           <optional>true</optional>
+       </dependency>
+       <dependency>
+           <groupId>com.sun.xml.ws</groupId>
+           <artifactId>httpspi-servlet</artifactId>
+           <version>${project.version}</version>
+           <optional>true</optional>
+       </dependency>
+       <dependency>
+           <groupId>com.sun.xml.ws</groupId>
+           <artifactId>servlet</artifactId>
+           <version>${project.version}</version>
+           <optional>true</optional>
+       </dependency>
         <dependency>
             <groupId>javax.xml.soap</groupId>
             <artifactId>javax.xml.soap-api</artifactId>

Affected Versions

[2.2.10]

[glassfishrobot]

Reported by @romain-grecourt

[glassfishrobot]

@lukasj said: thanks for the patch, it's under review now and hopefully will be merged to the master within a day or two

[glassfishrobot]

@romain-grecourt said: I also missed the same for bundles/jaxws-tools:

--- bundles/jaxws-tools/pom.xml
+++ bundles/jaxws-tools/pom.xml
@@ -71,6 +71,11 @@
             <groupId>com.sun.xml.bind</groupId>
             <artifactId>jaxb-jxc</artifactId>
         </dependency>
+   <dependency>
+       <groupId>com.sun.xml.ws</groupId>
+       <artifactId>wscompile</artifactId>
+       <version>${project.version}</version>
+   </dependency>
     </dependencies>

     <modules>

[glassfishrobot]

@lukasj said: https://java.net/projects/jax-ws/sources/git/revision/c9eb576b9af821f5408ebffb26c13aee23d93fbf https://java.net/projects/jax-ws/sources/git/revision/6c566b67b3490a65441302de652948db02539881

[glassfishrobot]

This issue was imported from java.net JIRA JAX_WS-1169

[glassfishrobot]

Marked as fixed on Thursday, January 29th 2015, 12:58:46 pm