Exception swallowing in wsImport()

glassfishrobot commented 16 years ago

In WsImportMojo.java we have exception handling that swallows useful info on root causes which makes life difficult for users.

private void wsImport( ArrayList args ) throws MojoExecutionException { try { final ClassLoader cl = Invoker.createClassLoader(Thread.currentThread ().getContextClassLoader()); Class c = cl.loadClass("com.sun.tools.ws.wscompile.WsimportTool"); Object tool = c.getConstructor(OutputStream.class).newInstance (System.out); String[] ar = args.toArray( new String[args.size()] ); Boolean result = (Boolean)c.getMethod("run", ar.getClass()).invoke (tool, new Object[]

{ar}

); if ( !result )

{ throw new MojoExecutionException( "Error executing: wsimport " + args); }

// New handler complementing thrown exception above } catch (MojoExecutionException e)

{ throw e; }

catch (Exception e)

{ // Corrected throw to include second param 'e' (chaining) throw new MojoExecutionException( "Error executing: wsimport " + args, e ); }

}

Without this we cannot see the reasons why the function is failing. See also ... http://forums.java.net/jive/thread.jspa?messageID=293732&#293732

PS I would contribute if I knew how.

Environment

Operating System: All Platform: All