[PORT 2.2.8] JAVASERVERFACES-3552 - Complete rollback of injectability for components, behaviors, validators and converters. (was: Major performance regression with Util.classHasAnnotations)

[javaserverfaces]

Since JSF 2.2 CDI injection should work for component, validators etc. Thus for all relevant classes InjectionTarget instances are created. This is determined by scanning the classes for annotations. Unfortunately also @Deprecated annotations are considered relevant. This reduces the overall performance for larger views massively.

The attached patch checks if the only annotation used in a class is @Deprecated. If so, it is considered not injectable.

Affected Versions

[2.2.8]

[javaserverfaces]

Reported by cappi

[javaserverfaces]

@edburns said: Start work on 2.2.8-05.

SECTION: Modified Files

M jsf-tools/pom.xml M test/unit/pom.xml M test/javaee6web/el/basic/pom.xml M test/javaee6web/el/pom.xml M test/javaee6web/ajax/pom.xml M test/javaee6web/pom.xml M test/cluster/javaee6web/flow/basic_faces_flow_call/pom.xml M test/cluster/javaee6web/flow/pom.xml M test/cluster/javaee6web/viewScoped/pom.xml M test/cluster/javaee6web/pom.xml M test/cluster/pom.xml M test/cluster/servlet25/bytearrayguard/pom.xml M test/cluster/servlet25/pom.xml M test/cluster/servlet25/flash/basic/pom.xml M test/cluster/servlet25/flash/pom.xml M test/cluster/servlet25/flash/reaper/pom.xml M test/javaee6/resource/cacheLastMod/war-test/pom.xml M test/javaee6/resource/cacheLastMod/ear/pom.xml M test/javaee6/resource/cacheLastMod/war/pom.xml M test/javaee6/resource/cacheLastMod/pom.xml M test/javaee6/resource/cacheLastMod/jar/pom.xml M test/javaee6/resource/pom.xml M test/javaee6/pom.xml M test/protocolaware/pom.xml M test/protocolaware/flash/basic/pom.xml M test/protocolaware/flash/pom.xml M test/selenium/agnostic/shared/pom.xml M test/selenium/agnostic/pom.xml M test/selenium/pom.xml M test/javaee7/cdi/multi-tenant/cdi-jsp-only-app-sets-tccl/pom.xml M test/javaee7/cdi/multi-tenant/pom.xml M test/javaee7/cdi/multi-tenant/cdi-app-sets-tccl/pom.xml M test/javaee7/cdi/noBeansXml/pom.xml M test/javaee7/cdi/pom.xml M test/javaee7/cdi/beanValidatorCdi/pom.xml M test/javaee7/cdi/initDestroy/pom.xml M test/javaee7/beanValidation/pom.xml M test/javaee7/beanValidation/methodValidation/pom.xml M test/javaee7/el/basicLambda/pom.xml M test/javaee7/el/pom.xml M test/javaee7/facelets/pom.xml M test/javaee7/facelets/ui/pom.xml M test/javaee7/pom.xml M test/javaee7/action/basic/pom.xml M test/javaee7/action/pom.xml M test/glassfish/undeploy/undeploy1/pom.xml M test/glassfish/undeploy/undeploy2/pom.xml M test/glassfish/undeploy/pom.xml M test/glassfish/facelets/core/pom.xml M test/glassfish/facelets/pom.xml M test/glassfish/pom.xml M test/glassfish/request_char_encoding/pom.xml M test/glassfish/bundle22/pom.xml M test/glassfish/request_char_encoding2/pom.xml M test/groovy/basic/pom.xml M test/groovy/pom.xml M test/groovy/weldAware/pom.xml M test/servlet30/navigation/pom.xml M test/servlet30/el/basic/pom.xml M test/servlet30/el/decorate-context/app/pom.xml M test/servlet30/el/decorate-context/decorate-facescontextfactory/pom.xml M test/servlet30/el/decorate-context/decorate-exceptionhandlerfactory/pom.xml M test/servlet30/el/decorate-context/pom.xml M test/servlet30/el/pom.xml M test/servlet30/multi-tenant/app-sets-tccl/pom.xml M test/servlet30/multi-tenant/pom.xml M test/servlet30/multi-tenant/app-servlet-uses-factoryfinder-from-init/pom.xml M test/servlet30/component/pom.xml M test/servlet30/composite/pom.xml M test/servlet30/ajax/pom.xml M test/servlet30/dynamic/pom.xml M test/servlet30/facelets/c/pom.xml M test/servlet30/facelets/html/pom.xml M test/servlet30/facelets/coreEmptyAsNull/pom.xml M test/servlet30/facelets/core/pom.xml M test/servlet30/facelets/pom.xml M test/servlet30/facelets/ui/pom.xml M test/servlet30/factory/pom.xml M test/servlet30/custom-viewroot-viewscope/pom.xml M test/servlet30/pom.xml M test/servlet30/mapping/exact/pom.xml M test/servlet30/mapping/pom.xml M test/servlet30/systest/pom.xml M test/servlet31/facelets/html/pom.xml M test/servlet31/facelets/coreEmptyAsNull/pom.xml M test/servlet31/facelets/pom.xml M test/servlet31/facelets/ui/pom.xml M test/servlet31/pom.xml M test/quality/pom.xml M test/pom.xml M test/weblogic/pom.xml M test/weblogic/wls1214/elBackwardCompatible/pom.xml M test/weblogic/wls1214/facelets/core/pom.xml M test/weblogic/wls1214/facelets/pom.xml M test/weblogic/wls1214/pom.xml M test/performance/pom.xml M test/weblogic12c/pom.xml M test/weblogic12c/request_char_encoding/pom.xml M test/agnostic/context/regular/pom.xml M test/agnostic/context/initFacesContext/pom.xml M test/agnostic/context/pom.xml M test/agnostic/vdl/facelets/contracts/basic_contract_in_jar/pom.xml M test/agnostic/vdl/facelets/contracts/extended/extended_contracts/pom.xmlM test/agnostic/vdl/facelets/contracts/extended/extended_blue/pom.xml M test/agnostic/vdl/facelets/contracts/extended/extended_base/pom.xml M test/agnostic/vdl/facelets/contracts/extended/extended_red/pom.xml M test/agnostic/vdl/facelets/contracts/extended/pom.xml M test/agnostic/vdl/facelets/contracts/basic/pom.xml M test/agnostic/vdl/facelets/contracts/sample/pom.xml M test/agnostic/vdl/facelets/contracts/vhosts/pom.xml M test/agnostic/vdl/facelets/contracts/simple/pom.xml M test/agnostic/vdl/facelets/contracts/basic_contract_jar/pom.xml M test/agnostic/vdl/facelets/contracts/pom.xml M test/agnostic/vdl/facelets/contracts/viewroot/pom.xml M test/agnostic/vdl/facelets/only_faces_config_in_jar/app/pom.xml M test/agnostic/vdl/facelets/only_faces_config_in_jar/pom.xml M test/agnostic/vdl/facelets/only_faces_config_in_jar/jar/pom.xml M test/agnostic/vdl/facelets/pom.xml M test/agnostic/vdl/pom.xml M test/agnostic/facelets/findChild/pom.xml M test/agnostic/facelets/cc/pom.xml M test/agnostic/facelets/viewAction/newsReader/pom.xml M test/agnostic/facelets/viewAction/pom.xml M test/agnostic/facelets/ccInJar/pom.xml M test/agnostic/facelets/pom.xml M test/agnostic/facelets/processing/html5/pom.xml M test/agnostic/facelets/processing/escaping01/pom.xml M test/agnostic/facelets/processing/pom.xml M test/agnostic/externalContext/basic/pom.xml M test/agnostic/externalContext/pom.xml M test/agnostic/renderKit/basic/pom.xml M test/agnostic/renderKit/noLinkDecoration/pom.xml M test/agnostic/renderKit/passthrough/pom.xml M test/agnostic/renderKit/pom.xml M test/agnostic/resource/basic/pom.xml M test/agnostic/resource/relocated/pom.xml M test/agnostic/resource/pom.xml M test/agnostic/stateSaving/serializeServerState/pom.xml M test/agnostic/stateSaving/disableIdUniqueness/pom.xml M test/agnostic/stateSaving/basic/pom.xml M test/agnostic/stateSaving/pom.xml M test/agnostic/pom.xml M test/agnostic/replace-vr-add-er/pom.xml M test/agnostic/flash/basic/pom.xml M test/agnostic/flash/chunkRedirect/pom.xml M test/agnostic/flash/custom/pom.xml M test/agnostic/flash/pom.xml M test/agnostic/lifecycle/basic/pom.xml M test/agnostic/lifecycle/unserializableServerState_negative/pom.xml M test/agnostic/lifecycle/unserializableServerState_positive/pom.xml M test/agnostic/lifecycle/optionsRequest/pom.xml M test/agnostic/lifecycle/clientWindow/pom.xml M test/agnostic/lifecycle/facesServletAccess/pom.xml M test/agnostic/lifecycle/debugObjectOutputStream/pom.xml M test/agnostic/lifecycle/pom.xml M test/agnostic/lifecycle/csrf/pom.xml M test/agnostic/application/navigation/pom.xml M test/agnostic/application/basic/pom.xml M test/agnostic/application/navigationJSF2/pom.xml M test/agnostic/application/listener/pom.xml M test/agnostic/application/localeConfig/pom.xml M test/agnostic/application/runtimeConfig/pom.xml M test/agnostic/application/pom.xml M test/agnostic/config/basic/pom.xml M test/agnostic/config/embedConfig/pom.xml M test/agnostic/config/lowerCase/pom.xml M test/agnostic/config/configFile/pom.xml M test/agnostic/config/extraConfig/pom.xml M test/agnostic/config/pom.xml M test/agnostic/converter/basic/pom.xml M test/agnostic/converter/converterThrowsNPE/pom.xml M test/agnostic/converter/pom.xml M test/agnostic/scope/session/pom.xml M test/agnostic/scope/pom.xml M test/agnostic/ajax-namespace/pom.xml M test/web-profile/facelets/core/pom.xml M test/web-profile/facelets/pom.xml M test/web-profile/flow/basic-multi-page-fdl-in-web-inf/pom.xml M test/web-profile/flow/multi-page-from-jar/app/pom.xml M test/web-profile/flow/multi-page-from-jar/pom.xml M test/web-profile/flow/multi-page-from-jar/jar/pom.xml M test/web-profile/flow/basic-multi-page/pom.xml M test/web-profile/flow/return_from_depth/pom.xml M test/web-profile/flow/basic-implicit/pom.xml M test/web-profile/flow/pom.xml M test/web-profile/flow/nested_flows/pom.xml M test/web-profile/flow/basic_implicit_in_jar/pom.xml M test/web-profile/flow/defining_document_id/app/pom.xml M test/web-profile/flow/defining_document_id/pom.xml M test/web-profile/flow/defining_document_id/jar01/pom.xml M test/web-profile/flow/defining_document_id/jar02/pom.xml M test/web-profile/flow/basic_switch/pom.xml M test/web-profile/flow/parameter_faces_flow_call/pom.xml M test/web-profile/flow/basic_faces_flow_call/pom.xml M test/web-profile/flow/basic_implicit_template/pom.xml M test/web-profile/flow/factory/pom.xml M test/web-profile/flow/intermediate/pom.xml M test/web-profile/flow/basic_method_call/pom.xml M test/web-profile/flow/view_node_differences/pom.xml M test/web-profile/flow/basic-empty-flow-def/pom.xml M test/web-profile/renderKit/basic/pom.xml M test/web-profile/renderKit/pom.xml M test/web-profile/renderKit/fileUploadFailure/pom.xml M test/web-profile/stateSaving/basic/pom.xml M test/web-profile/stateSaving/pom.xml M test/web-profile/scope/view/pom.xml M test/web-profile/scope/pom.xml M test/web-profile/adf/basic/pom.xml M test/web-profile/adf/pom.xml M test/web-profile/pom.xml M test/web-profile/multi_templating/basic/pom.xml M test/web-profile/multi_templating/pom.xml M test/util/pom.xml M nbproject/project.xml M common/ant/common.xml

Sending common/ant/common.xml Sending jsf-tools/pom.xml Sending nbproject/project.xml Sending test/agnostic/ajax-namespace/pom.xml Sending test/agnostic/application/basic/pom.xml Sending test/agnostic/application/listener/pom.xml Sending test/agnostic/application/localeConfig/pom.xml Sending test/agnostic/application/navigation/pom.xml Sending test/agnostic/application/navigationJSF2/pom.xml Sending test/agnostic/application/pom.xml Sending test/agnostic/application/runtimeConfig/pom.xml Sending test/agnostic/config/basic/pom.xml Sending test/agnostic/config/configFile/pom.xml Sending test/agnostic/config/embedConfig/pom.xml Sending test/agnostic/config/extraConfig/pom.xml Sending test/agnostic/config/lowerCase/pom.xml Sending test/agnostic/config/pom.xml Sending test/agnostic/context/initFacesContext/pom.xml Sending test/agnostic/context/pom.xml Sending test/agnostic/context/regular/pom.xml Sending test/agnostic/converter/basic/pom.xml Sending test/agnostic/converter/converterThrowsNPE/pom.xml Sending test/agnostic/converter/pom.xml Sending test/agnostic/externalContext/basic/pom.xml Sending test/agnostic/externalContext/pom.xml Sending test/agnostic/facelets/cc/pom.xml Sending test/agnostic/facelets/ccInJar/pom.xml Sending test/agnostic/facelets/findChild/pom.xml Sending test/agnostic/facelets/pom.xml Sending test/agnostic/facelets/processing/escaping01/pom.xml Sending test/agnostic/facelets/processing/html5/pom.xml Sending test/agnostic/facelets/processing/pom.xml Sending test/agnostic/facelets/viewAction/newsReader/pom.xml Sending test/agnostic/facelets/viewAction/pom.xml Sending test/agnostic/flash/basic/pom.xml Sending test/agnostic/flash/chunkRedirect/pom.xml Sending test/agnostic/flash/custom/pom.xml Sending test/agnostic/flash/pom.xml Sending test/agnostic/lifecycle/basic/pom.xml Sending test/agnostic/lifecycle/clientWindow/pom.xml Sending test/agnostic/lifecycle/csrf/pom.xml Sending test/agnostic/lifecycle/debugObjectOutputStream/pom.xml Sending test/agnostic/lifecycle/facesServletAccess/pom.xml Sending test/agnostic/lifecycle/optionsRequest/pom.xml Sending test/agnostic/lifecycle/pom.xml Sending test/agnostic/lifecycle/unserializableServerState_negative/pom.xml Sending test/agnostic/lifecycle/unserializableServerState_positive/pom.xml Sending test/agnostic/pom.xml Sending test/agnostic/renderKit/basic/pom.xml Sending test/agnostic/renderKit/noLinkDecoration/pom.xml Sending test/agnostic/renderKit/passthrough/pom.xml Sending test/agnostic/renderKit/pom.xml Sending test/agnostic/replace-vr-add-er/pom.xml Sending test/agnostic/resource/basic/pom.xml Sending test/agnostic/resource/pom.xml Sending test/agnostic/resource/relocated/pom.xml Sending test/agnostic/scope/pom.xml Sending test/agnostic/scope/session/pom.xml Sending test/agnostic/stateSaving/basic/pom.xml Sending test/agnostic/stateSaving/disableIdUniqueness/pom.xml Sending test/agnostic/stateSaving/pom.xml Sending test/agnostic/stateSaving/serializeServerState/pom.xml Sending test/agnostic/vdl/facelets/contracts/basic/pom.xml Sending test/agnostic/vdl/facelets/contracts/basic_contract_in_jar/pom.xml Sending test/agnostic/vdl/facelets/contracts/basic_contract_jar/pom.xml Sending test/agnostic/vdl/facelets/contracts/extended/extended_base/pom.xml Sending test/agnostic/vdl/facelets/contracts/extended/extended_blue/pom.xml Sending test/agnostic/vdl/facelets/contracts/extended/extended_contracts/pom.xml Sending test/agnostic/vdl/facelets/contracts/extended/extended_red/pom.xml Sending test/agnostic/vdl/facelets/contracts/extended/pom.xml Sending test/agnostic/vdl/facelets/contracts/pom.xml Sending test/agnostic/vdl/facelets/contracts/sample/pom.xml Sending test/agnostic/vdl/facelets/contracts/simple/pom.xml Sending test/agnostic/vdl/facelets/contracts/vhosts/pom.xml Sending test/agnostic/vdl/facelets/contracts/viewroot/pom.xml Sending test/agnostic/vdl/facelets/only_faces_config_in_jar/app/pom.xml Sending test/agnostic/vdl/facelets/only_faces_config_in_jar/jar/pom.xml Sending test/agnostic/vdl/facelets/only_faces_config_in_jar/pom.xml Sending test/agnostic/vdl/facelets/pom.xml Sending test/agnostic/vdl/pom.xml Sending test/cluster/javaee6web/flow/basic_faces_flow_call/pom.xml Sending test/cluster/javaee6web/flow/pom.xml Sending test/cluster/javaee6web/pom.xml Sending test/cluster/javaee6web/viewScoped/pom.xml Sending test/cluster/pom.xml Sending test/cluster/servlet25/bytearrayguard/pom.xml Sending test/cluster/servlet25/flash/basic/pom.xml Sending test/cluster/servlet25/flash/pom.xml Sending test/cluster/servlet25/flash/reaper/pom.xml Sending test/cluster/servlet25/pom.xml Sending test/glassfish/bundle22/pom.xml Sending test/glassfish/facelets/core/pom.xml Sending test/glassfish/facelets/pom.xml Sending test/glassfish/pom.xml Sending test/glassfish/request_char_encoding/pom.xml Sending test/glassfish/request_char_encoding2/pom.xml Sending test/glassfish/undeploy/pom.xml Sending test/glassfish/undeploy/undeploy1/pom.xml Sending test/glassfish/undeploy/undeploy2/pom.xml Sending test/groovy/basic/pom.xml Sending test/groovy/pom.xml Sending test/groovy/weldAware/pom.xml Sending test/javaee6/pom.xml Sending test/javaee6/resource/cacheLastMod/ear/pom.xml Sending test/javaee6/resource/cacheLastMod/jar/pom.xml Sending test/javaee6/resource/cacheLastMod/pom.xml Sending test/javaee6/resource/cacheLastMod/war/pom.xml Sending test/javaee6/resource/cacheLastMod/war-test/pom.xml Sending test/javaee6/resource/pom.xml Sending test/javaee6web/ajax/pom.xml Sending test/javaee6web/el/basic/pom.xml Sending test/javaee6web/el/pom.xml Sending test/javaee6web/pom.xml Sending test/javaee7/action/basic/pom.xml Sending test/javaee7/action/pom.xml Sending test/javaee7/beanValidation/methodValidation/pom.xml Sending test/javaee7/beanValidation/pom.xml Sending test/javaee7/cdi/beanValidatorCdi/pom.xml Sending test/javaee7/cdi/initDestroy/pom.xml Sending test/javaee7/cdi/multi-tenant/cdi-app-sets-tccl/pom.xml Sending test/javaee7/cdi/multi-tenant/cdi-jsp-only-app-sets-tccl/pom.xml Sending test/javaee7/cdi/multi-tenant/pom.xml Sending test/javaee7/cdi/noBeansXml/pom.xml Sending test/javaee7/cdi/pom.xml Sending test/javaee7/el/basicLambda/pom.xml Sending test/javaee7/el/pom.xml Sending test/javaee7/facelets/pom.xml Sending test/javaee7/facelets/ui/pom.xml Sending test/javaee7/pom.xml Sending test/performance/pom.xml Sending test/pom.xml Sending test/protocolaware/flash/basic/pom.xml Sending test/protocolaware/flash/pom.xml Sending test/protocolaware/pom.xml Sending test/quality/pom.xml Sending test/selenium/agnostic/pom.xml Sending test/selenium/agnostic/shared/pom.xml Sending test/selenium/pom.xml Sending test/servlet30/ajax/pom.xml Sending test/servlet30/component/pom.xml Sending test/servlet30/composite/pom.xml Sending test/servlet30/custom-viewroot-viewscope/pom.xml Sending test/servlet30/dynamic/pom.xml Sending test/servlet30/el/basic/pom.xml Sending test/servlet30/el/decorate-context/app/pom.xml Sending test/servlet30/el/decorate-context/decorate-exceptionhandlerfactory/pom.xml Sending test/servlet30/el/decorate-context/decorate-facescontextfactory/pom.xml Sending test/servlet30/el/decorate-context/pom.xml Sending test/servlet30/el/pom.xml Sending test/servlet30/facelets/c/pom.xml Sending test/servlet30/facelets/core/pom.xml Sending test/servlet30/facelets/coreEmptyAsNull/pom.xml Sending test/servlet30/facelets/html/pom.xml Sending test/servlet30/facelets/pom.xml Sending test/servlet30/facelets/ui/pom.xml Sending test/servlet30/factory/pom.xml Sending test/servlet30/mapping/exact/pom.xml Sending test/servlet30/mapping/pom.xml Sending test/servlet30/multi-tenant/app-servlet-uses-factoryfinder-from-init/pom.xml Sending test/servlet30/multi-tenant/app-sets-tccl/pom.xml Sending test/servlet30/multi-tenant/pom.xml Sending test/servlet30/navigation/pom.xml Sending test/servlet30/pom.xml Sending test/servlet30/systest/pom.xml Sending test/servlet31/facelets/coreEmptyAsNull/pom.xml Sending test/servlet31/facelets/html/pom.xml Sending test/servlet31/facelets/pom.xml Sending test/servlet31/facelets/ui/pom.xml Sending test/servlet31/pom.xml Sending test/unit/pom.xml Sending test/util/pom.xml Sending test/web-profile/adf/basic/pom.xml Sending test/web-profile/adf/pom.xml Sending test/web-profile/facelets/core/pom.xml Sending test/web-profile/facelets/pom.xml Sending test/web-profile/flow/basic-empty-flow-def/pom.xml Sending test/web-profile/flow/basic-implicit/pom.xml Sending test/web-profile/flow/basic-multi-page/pom.xml Sending test/web-profile/flow/basic-multi-page-fdl-in-web-inf/pom.xml Sending test/web-profile/flow/basic_faces_flow_call/pom.xml Sending test/web-profile/flow/basic_implicit_in_jar/pom.xml Sending test/web-profile/flow/basic_implicit_template/pom.xml Sending test/web-profile/flow/basic_method_call/pom.xml Sending test/web-profile/flow/basic_switch/pom.xml Sending test/web-profile/flow/defining_document_id/app/pom.xml Sending test/web-profile/flow/defining_document_id/jar01/pom.xml Sending test/web-profile/flow/defining_document_id/jar02/pom.xml Sending test/web-profile/flow/defining_document_id/pom.xml Sending test/web-profile/flow/factory/pom.xml Sending test/web-profile/flow/intermediate/pom.xml Sending test/web-profile/flow/multi-page-from-jar/app/pom.xml Sending test/web-profile/flow/multi-page-from-jar/jar/pom.xml Sending test/web-profile/flow/multi-page-from-jar/pom.xml Sending test/web-profile/flow/nested_flows/pom.xml Sending test/web-profile/flow/parameter_faces_flow_call/pom.xml Sending test/web-profile/flow/pom.xml Sending test/web-profile/flow/return_from_depth/pom.xml Sending test/web-profile/flow/view_node_differences/pom.xml Sending test/web-profile/multi_templating/basic/pom.xml Sending test/web-profile/multi_templating/pom.xml Sending test/web-profile/pom.xml Sending test/web-profile/renderKit/basic/pom.xml Sending test/web-profile/renderKit/fileUploadFailure/pom.xml Sending test/web-profile/renderKit/pom.xml Sending test/web-profile/scope/pom.xml Sending test/web-profile/scope/view/pom.xml Sending test/web-profile/stateSaving/basic/pom.xml Sending test/web-profile/stateSaving/pom.xml Sending test/weblogic/pom.xml Sending test/weblogic/wls1214/elBackwardCompatible/pom.xml Sending test/weblogic/wls1214/facelets/core/pom.xml Sending test/weblogic/wls1214/facelets/pom.xml Sending test/weblogic/wls1214/pom.xml Sending test/weblogic12c/pom.xml Sending test/weblogic12c/request_char_encoding/pom.xml Transmitting file data ....................................................................................................................................................................................................................... Committed revision 14016.

[javaserverfaces]

@edburns said: Reopen to fix PMD issue.

[javaserverfaces]

@edburns said: BugDB 20064720

[javaserverfaces]

File: changebundle.txt Attached By: @edburns

[javaserverfaces]

File: DeprecatedNotInjectible.patch Attached By: @edburns

[javaserverfaces]

Issue-Links: clones JAVASERVERFACES-3552

[javaserverfaces]

This issue was imported from java.net JIRA JAVASERVERFACES-3564

[javaserverfaces]

Marked as fixed on Wednesday, December 10th 2014, 9:04:38 am