javaee / mojarra

PLEASE NOTE: This project has moved to Eclipse Foundation and will be archived under the JavaEE GitHub Organization. After Feb. 1, 2021, the new location will be github.com/javaee/mojarra. Mojarra - Oracle's implementation of the JavaServer Faces specification
https://github.com/eclipse-ee4j/mojarra
Other
164 stars 58 forks source link

UIComponentBase.validateId() thrown exception should be more explanatory #4375

Open Quix0r opened 6 years ago

Quix0r commented 6 years ago

Please see following excerpt from a thrown exception I currently try to fix but I'm confused where (JSF template/view) it origins from.

java.lang.IllegalArgumentException:  
        at javax.faces.component.UIComponentBase.validateId(UIComponentBase.java:605)
        at javax.faces.component.UIComponentBase.setId(UIComponentBase.java:422)
        at com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.assignUniqueId(ComponentTagHandlerDelegateImpl.java:438)
[...]

It would be nice to have some message being added to that exception, like: Invalid id x/y$z or so then I can directly see where that exception comes from (one of my templates, of course).

JSF 2.3.5

arjantijms commented 6 years ago

I agree, the messages should be clearer here.

I’ve encountered this multiple times myself as well.

On Saturday, July 7, 2018, Roland Häder notifications@github.com wrote:

Please see following excerpt from a thrown exception I currently try to fix but I'm confused where (JSF template/view) it origins from.

java.lang.IllegalArgumentException: at javax.faces.component.UIComponentBase.validateId(UIComponentBase.java:605) at javax.faces.component.UIComponentBase.setId(UIComponentBase.java:422) at com.sun.faces.facelets.tag.jsf.ComponentTagHandlerDelegateImpl.assignUniqueId(ComponentTagHandlerDelegateImpl.java:438) [...]

It would be nice to have some message being added to that exception, like: Invalid id x/y$z or so then I can directly see where that exception comes from (one of my templates, of course).

JSF 2.3.5

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/javaserverfaces/mojarra/issues/4375, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5XTvzHbt4zaiGS3yzWt5G9s1ET83XGks5uEROrgaJpZM4VGeYg .

Quix0r commented 6 years ago

Any news here? I would really appreciate if this issue is quickly solved (and no big change, for sure). Maybe I can find some time to do it myself but no promise here.