search

javaee / mojarra

PLEASE NOTE: This project has moved to Eclipse Foundation and will be archived under the JavaEE GitHub Organization. After Feb. 1, 2021, the new location will be github.com/javaee/mojarra. Mojarra - Oracle's implementation of the JavaServer Faces specification
https://github.com/eclipse-ee4j/mojarra
Other
164 stars 58 forks source link

Simplify the concrete Validator and DateTimeConverter implementations #645

Closed javaserverfaces closed 17 years ago

javaserverfaces commented 17 years ago

These classes use ivars to determine if a primitive property has been set. This is undesirable:

More info on the second bullet item:

In Trinidad, we extend the standard validators, like the doubleRangeValidator, but the "logic" of the validate is inherited. Inside of save/restore State methods, we delegate to the FacesBean instance, which takes care of saving / restoring all properties, like maximum or some Trinidad extra properties like "messageDetailMaximum". See [2] for the full source code.

When using Trinidad on top of the RI (and client side validation is DISABLED), there are some issues (see [1]). It looks like there is a private property used the the RI (DoubleRange)Validator to indicate if maximum or minimum has been set (and these properties are also saved / restored). Since this is private, it's "odd" to add this property to Trinidad's (DoubleRange)Validator as well, to get it working with the RI, isnt' it ?

I checked the MyFaces IMPL code of (DoubleRange)Validator (see [3]) and it doesn't use such a property. So here, this combination (MyFaces

Environment

Operating System: All Platform: All

Affected Versions

[1.2_04]

javaserverfaces commented 17 years ago

Reported by @rlubke

javaserverfaces commented 17 years ago

@rlubke said: Targeting for what will hopefully be FCS build.

javaserverfaces commented 17 years ago

@rlubke said: Created an attachment (id=552) Proposed Fix (ver 1)

javaserverfaces commented 17 years ago

@rlubke said: Change bundle attached. Review pending.

javaserverfaces commented 17 years ago

jdlee said: r=jdlee

javaserverfaces commented 17 years ago

@rlubke said: Fix checked in to the JSF_1_2X_ROLLING branch and the HEAD.

javaserverfaces commented 12 years ago

@manfredriem said: Closing issue out

javaserverfaces commented 17 years ago

File: changebundle.txt Attached By: @rlubke

javaserverfaces commented 17 years ago

Was assigned to rlubke

javaserverfaces commented 7 years ago

This issue was imported from java.net JIRA JAVASERVERFACES-641

javaserverfaces commented 17 years ago

Marked as fixed on Wednesday, September 26th 2007, 5:25:09 am