search

javafxports / javafxmobile-plugin

A gradle plugin for building mobile applications in java.
BSD 3-Clause "New" or "Revised" License
42 stars 19 forks source link

better Exception information when Retrobuffer fails #62

Closed johanvos closed 6 years ago

johanvos commented 6 years ago

When running ./gradlew androidInstall using Java 9, Retrobuffer might fail. The current exception is too cryptic and doesn't provide the developer with a hint:

SEVERE: Failed to run Retrobuffer java.lang.IllegalArgumentException at org.objectweb.asm.ClassReader.(Unknown Source) at org.objectweb.asm.ClassReader.(Unknown Source) at org.javafxports.retrobuffer.ClassAnalyzer.analyze(ClassAnalyzer.java:48) at org.javafxports.retrobuffer.Retrobuffer$1.visitClass(Retrobuffer.java:59) at org.javafxports.retrobuffer.ClasspathVisitor.visitFile(ClasspathVisitor.java:59) at org.javafxports.retrobuffer.ClasspathVisitor.visitFile(ClasspathVisitor.java:41) at java.base/java.nio.file.Files.walkFileTree(Files.java:2713) at java.base/java.nio.file.Files.walkFileTree(Files.java:2785) at org.javafxports.retrobuffer.Retrobuffer.run(Retrobuffer.java:56) at org.javafxports.retrobuffer.Main.main(Main.java:45)

It would help providing the file where this exception occurred, and even better it should also print the cause (e.g. wrong major/minor?)

tiainen commented 6 years ago

Duplicate of #32