search

javajawa / DoCitten

DoCitten: The Cutest IRC bot ever [citation needed]
2 stars 3 forks source link

Make should check JDK version #10

Closed javajawa closed 9 years ago

javajawa commented 11 years ago

Current code-base is not compatible with JDKs < 7. This should be checked for in the Makefile, as some files are source compatible with JDK5/6, leading to later build problems.

Darael commented 10 years ago

Is this not resolved by 1a6bb1a, following 9e9fd66b?

Darael commented 10 years ago

I mean, the current version insists on JDK7, which will presumably be a problem eventually when people start using JDK8, but that should be a good way off.

javajawa commented 10 years ago

I don't currently have a machine running JDK < 7 to test 1a6bb1a against, so I haven't yet closed the issue. The JDK 8 future issue is also a good point.

javajawa commented 10 years ago

Also, I've just noticed that, 516c6cf60a is still testing the static string javac rather than $(JAVAC)

javajawa commented 9 years ago

Closing as an stale issue