javalent / admonitions

Adds admonition block-styled content to Obsidian.md
MIT License
1.09k stars 71 forks source link

Advanced Tables not working in Admonition #163

Closed daniellsh closed 1 year ago

daniellsh commented 2 years ago

I noticed that Advanced tables stop working in Admonition recently, after I updated both plugin. Now within the code block of Admonition, the Advance Table stop auto generated like it used to be. But when outside the Admonition code block the tables are working fine. Not sure if anyone else encountered the same problem?

current version:

valentine195 commented 2 years ago

This is likely due to an old bug between markdown processors. Try disabling Admonitions, restarting Obsidian, and re-enabling Admonitions.

BrandonSLockey commented 2 years ago

This is likely due to an old bug between markdown processors. Try disabling Admonitions, restarting Obsidian, and re-enabling Admonitions.

Admonitions table will render (if you manually type out table |---|---|), but pressing Tab to create table or using any of these Menu options:

image

does not work inside the admonitions block despite restarting/re-enabling

sigrunixia commented 1 year ago

After doing some extensive testing, I can confirm this behavior is still present. However, I suspect this is not something that can be fixed because of how the code block tries to process code by prism's rules and expectations (and admonitions, being a code block), is subject to this.

Advanced Tables, as well, is unable to detect that a table exists within the code block.

I am going to close this thread as the workaround to this to create the table outside the code block and surround it by an admonition code block. This is more than just an Admontions issue (as the same thing happens in other codeblocks), so this now feature request, as it was changes within Obsidian that changed the behavior in the first place, is more suited for the Obsidian forums.