search

javalent / admonitions

Adds admonition block-styled content to Obsidian.md
MIT License
1.04k stars 67 forks source link

Insert Custom Callout, with Collapsed by default enabled, not "-" inserted #335

Open BananenRitter opened 4 months ago

BananenRitter commented 4 months ago

Check for existing bug reports before submitting.

Expected Behavior

Options/ Admonitions & Callouts/

  1. Collapsible by Default: On
  2. Default Collapse Type: Closed

Should insert - before ] to enable collapsible function

Current behaviour

Reproduction

  1. When i go into the Options under Admonitions & Callouts

  2. and activate: Collapsible by Default

  3. as well as set Default Collapse Type to Closed

  4. Then use the Command Pallette to Insert a Callout

  5. A custom one if that matters

  6. Dont change anyting and just tab 3 times and press enter to insert

  7. The Callout is insert but the - after the ] is missing so its not collapsed by default

  8. However when i deactivate Collapsible by Default or set Default Collapse Type to: Open

  9. Then change the type from open to closed in the insert menu before inserting the Callout

  10. It works

Which Operating Systems are you using?

Obsidian Version Check

Obsidian version: v1.5.8, Installer version: v1.4.16

Plugin Version

Admonition version 10.2.0

Confirmation

Possible solution

The corresponding array is probably missing the symbol in it so its just a copying error.

Or the world is burning because of you! :D

I tested it in the Sandbox vault without any other plugins and the issue still persists

SYSTEM INFO: Obsidian version: v1.5.8 Installer version: v1.4.16 Operating system: Windows 10 Home 10.0.19045 Login status: not logged in Insider build toggle: off Live preview: on Base theme: dark Community theme: Minimal v7.4.6 Snippets enabled: 10 Restricted mode: off Plugins installed: 111 Plugins enabled: 66 1: Excalidraw v2.0.23 2: AutoMOC v1.4.0 3: Buttons v0.5.1 4: Google Calendar v1.10.14 5: Calendar v1.5.10 6: Citations v0.4.5 7: Copy button for code blocks v0.1.0 8: Dataview v0.5.64 9: Dictionary v2.22.0 10: Editor Syntax Highlight v0.1.3 11: Excel to Markdown Table v0.4.0 12: Find orphaned files and broken links v1.9.1 13: Footnote Shortcut v0.1.3 14: Kanban v1.5.3 15: Markdown Formatting Assistant v0.4.1 16: Pandoc Plugin v0.4.1 17: Recent Files v1.3.10 18: Tag Wrangler v0.6.1 19: Zotero Integration v3.1.7 20: Diagrams.net v1.0.4 21: Diagrams v1.5.0 22: Templater v2.2.3 23: Image Toolkit v1.4.1 24: Mousewheel Image zoom v1.0.21 25: Periodic Notes v0.0.17 26: Heatmap Calendar v0.6.0 27: Icon Shortcodes v0.9.7 28: Remember cursor position v1.0.8 29: Show Current File Path v0.5.2 30: MathLive v1.1.0 31: Extended MathJax v0.4.1 32: Go To Heading v0.2.2 33: Export To TeX v0.4.2 34: Quick Latex v2.6.5 35: Completr v3.2.0 36: Latex Suite v1.9.1 37: ExcaliBrain v0.2.14 38: Edit History v0.1.3 39: Automatic Table Of Contents v1.3.2 40: Navigate Cursor History v1.1.0 41: Keyboard Analyzer v0.1.3 42: Hotkey Helper v0.3.18 43: Metadata Menu v0.8.4 44: MetaEdit v1.8.2 45: Projects v1.17.1 46: Minimal Theme Settings v7.3.1 47: Style Settings v1.0.7 48: Callout Integrator v1.1.4 49: List Callouts v1.2.4 50: Callout Manager v1.0.1 51: Trash Explorer v1.2.2 52: Media Extended v3.0.4 53: Multi-Column Markdown v0.9.1 54: HTML Tabs v1.1.0 55: Custom File Explorer sorting v2.1.8 56: Advanced Tables v0.21.0 57: Doubleshift v2.2.1 58: Editing Toolbar v2.4.0 59: Juggl v1.5.0 60: Pane Relief v0.5.2 61: Breadcrumbs v3.6.11 62: Hover Editor v0.11.17 63: Supercharged Links v0.11.1 64: Markmind v1.9.1 65: Mindmap NextGen v1.9.0 66: Admonition v10.2.0

matar3 commented 1 month ago

It's the same for me. If in settings i choose "collapsible by default", it only applies to pre-existing types of callouts, but not for new custom callouts created with the plugin. You should add the option to make collapsible by default the custom callouts when creating them with Admonition. image

You should add the option in this window:

image