search

javalent / calendarium

The ultimate Obsidian plugin for crafting mind-bending fantasy and sci-fi calendars
MIT License
77 stars 10 forks source link

Calendar-specific settings layout broken on iPad #102

Open kristofferpeterhansel opened 7 months ago

kristofferpeterhansel commented 7 months ago

Check for existing bug reports before submitting.

Expected Behavior

When opening the settings for a given calendar. It should be possible to navigate to the various sub-pages though the left-hand tabs.

Current behaviour

The entire left-side tab-selector is gone.

Screenshot 2024-03-01 at 18 23 05

Reproduction

This seems to be 100% consistent. Simply go to modify any calendar though one of the two buttons (star or wrench - not really sure what whey they are both there BTW).

Settings for the calendar will open. But the left-hand pane is not there.

Which Operating Systems are you using?

Obsidian Version Check

1.5.8(126)

Plugin Version

1.0.5

Confirmation

Possible solution

No response

ebullient commented 7 months ago

The star is for folks like me that just use a preset with no chance of accidentally changing it. It should show fewer settings.

Settings are now shown in a new pop-over modal. Clicking anywhere outside of the modal will close it.

There is a new sidebar for the popover modal that is not rendering on iOS.

kristofferpeterhansel commented 7 months ago

The star is for folks like me that just use a preset with no chance of accidentally changing it. It should show fewer settings.

Okay. I twas a bit of an offhand comment just to point it out is a bit of a confusing UX. Maybe just have one button and enable more detailed editing on the general pane or something? 🤷

ebullient commented 7 months ago

There should be a left nav on that popover modal, and that is missing. So you're right.

I was just letting you know what the sparkle buttons are for (and there are some UX changes coming for that, too).

kristofferpeterhansel commented 6 months ago

Looks like this works for the "Custom Creator" button (although I didn't try it before. But the change looks like it would make a difference). But not when editing existing calendars.

valentine195 commented 6 months ago

Hmm, really? It uses the same thing. How odd

kristofferpeterhansel commented 6 months ago

Hmm, really? It uses the same thing. How odd

Yeah. I made sure it was 1.0.10. Reloaded it manually. Even force quit the app too. And still I don't see the left-hand tabs

kristofferpeterhansel commented 6 months ago

I am going to have to correct myself here. It works in the full editor (pencil icon?) but not the reduced editor (star icon).

Sorry. I thought I had checked both but I must not have.

valentine195 commented 5 months ago

@kristofferpeterhansel is this still an issue

kristofferpeterhansel commented 5 months ago

Yes. Still happens.

https://github.com/javalent/calendarium/assets/6907530/a423690a-a73a-42d7-b642-22667824a67a

Here I fist tap the quick creator. Close it and then the custom creator