search

javalent / dice-roller

Inline dice rolling for Obsidian.md
268 stars 28 forks source link

[Bug]: Rolling graphical dice ignores advantage and disadvantage #227

Closed Hapadbeep24 closed 10 months ago

Hapadbeep24 commented 1 year ago

Check for existing bug reports before submitting.

Expected Behavior

When rolling 2d20dh it should roll 2 d20 dice and drop the lowest value. Same with kh keeping the highest value.

Current behaviour

When rolling graphical dice, the advantage and disadvantage is ignored, and the dice roller adds the two rolls together regardless.

Reproduction

  1. Launch obsidian sandbox
  2. Install dice roller plugin
  3. Turn on "Display Formula With Results"
  4. Turn on "Display graphics for Dice View Rolls"
  5. Using the sidebar tool for dice roller, add 2 of the same dice, click "Adv" or "Dis" and roll
  6. With graphics on, the formula will display the two rolls and the sum
  7. With graphics off, the formula will display the two rolls and {n}d or {n}k depending on adv or dis

Which Operating Systems are you using?

Obsidian Version Check

1.3.5

Plugin Version

9.0.0

Confirmation

Possible solution

No response

hellquist commented 11 months ago

FWIW I have the same, on all platforms I've tried (Win, macOS, iOS and iPadOS in my case). Came here to see if it was filed already, and here we are.

valentine195 commented 10 months ago

This is fixed