javalent / dice-roller

Inline dice rolling for Obsidian.md

272 stars 28 forks source link

feat: Add colorful dice setting and default colors for standard rpg dice #228

Closed AlexBieg closed 1 year ago

AlexBieg commented 1 year ago

Overview

First off, I love the plugin. One helpful thing for me is being able to differentiate dice by color. So this PR adds in that functionality.

Adds a new boolean setting allowing users to turn on and off "colorful" dice
Adds default colors to standard RPG dice (d4-d20)

Screenshot 2023-07-14 at 12 34 33 PM

Testing

Tested locally with Obsidian 1.3.5
Tested updating the setting correctly updates dice colors without needing to refresh

Questions/Comments

I'm not a designer so feel free to push back on the colors
It would be nice to allow people to set each dice color, but I figured starting out with set colors was an okay first step
I won't be offended if you reject the PR, this was only like 20 minutes of my life 😄