adding a delay to fix race - Githubissues

javalent / dice-roller

Inline dice rolling for Obsidian.md

265 stars 27 forks source link

adding a delay to fix race #279

Closed xgdgsc closed 6 months ago

xgdgsc commented 7 months ago

Pull Request Description

fix https://github.com/javalent/dice-roller/issues/277 . I tested locally it fixes the issue for me.

Changes Proposed

[ ] adding a delay before modify file

Related Issues

fix https://github.com/javalent/dice-roller/issues/277

Checklist

[x] I have read the contribution guidelines and code of conduct.
[x] I have tested the changes locally and they are working as expected.
[ ] I have added appropriate comments and documentation for the code changes.
[ ] My code follows the coding style and standards of this project.
[ ] I have rebased my branch on the latest main (or master) branch.
[ ] All tests (if applicable) have passed successfully.
[ ] I have run linters and fixed any issues.
[ ] I have checked for any potential security issues or vulnerabilities.

xgdgsc commented 7 months ago

It doesn' t work on another computer. Someone mentioned at https://github.com/SilentVoid13/Templater/issues/924#issuecomment-1427185289 using vault.process instead might work?

valentine195 commented 6 months ago

It doesn' t work on another computer. Someone mentioned at SilentVoid13/Templater#924 (comment) using vault.process instead might work?

Damn, I just saw this. Oh well. I'll investigate.