javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
348 stars 72 forks source link

5E Stat Block not showing Traits/Actions if custom Traits/Actions added #156

Closed PaganApe closed 1 year ago

PaganApe commented 1 year ago

It appears that if you customise an existing monster stat block by adding a custom Trait or Action then it no longer shows any of the Traits/Actions from the source monster.

For example

monster: Elvish Veteran Archer
name: Zeno Windrider
traits:
    - [Description, Wears studded leather armour. Has Dexterity AC bonus]

would show only the specified Description trait, and not, for example, the Fey Ancestry trait that the "Elvish Veteran Archer" has.

PaganApe commented 1 year ago

Just for clarity, things like Languages, Skills and Armor Class are being displayed as expected, so at least some of the attributes from the source monster are being brought in correctly.

sigrunixia commented 1 year ago

Hi @PaganApe

If you are still having issues, can you please post your entire statblock code block you are using, as well as a screenshot of what does display?

PaganApe commented 1 year ago

So, as an example of the behaviour, if I bring in a standard Orc monster it looks like this:

image

image

But if I name an Orc and give him a custom trait, then it overwrites the Aggressive trait of the standard Orc and just displays my custom trait, in this example Description. Previously it would just add my custom trait to the base creature's traits.

image

image

This happens regardless of which monster I choose as the base creature, and also happens with Actions, so any custom Action will overwrite any Actions the original base creature has.

sigrunixia commented 1 year ago

If it previously worked and now does not, we certainly can to look into it further.

What do you think @valentine195? My guess is looking the plugin is for, or needs an indication to add versus replace. Adding such a toggle for that plus remove would be able to address #51 as well.

valentine195 commented 1 year ago

@sigrunixia the plugin has always replaced Trait arrays if specified in a monster. Syntax for making it additive can get a little wonky… maybe the plugin can look for trait_key+ in addition to trait_key

PaganApe commented 1 year ago

@sigrunixia the plugin has always replaced Trait arrays if specified in a monster. Syntax for making it additive can get a little wonky… maybe the plugin can look for trait_key+ in addition to trait_key

In the past, I've seen the plugin replace a Trait if you supply your own with the same name, but it's only recently that the whole Trait and Action sections are replaced if you provide a Trait or Action section of your own. A lot of my NPCs were created this way, using a base Monster and then naming and tweaking it to make it unique. If I check back through my NPCs they have now all lost the Traits and Actions that previously came through from the base monster.

PaganApe commented 1 year ago

Perfect, thank you for the prompt response.