javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
348 stars 72 forks source link

Traits+ section is doubling existing traits on the base monster #224

Closed Darthfett closed 1 year ago

Darthfett commented 1 year ago

Check for existing bug reports before submitting.

Expected Behavior

When using traits+, I expect new traits to be added to the monster's existing traits.

Current behaviour

New traits are added, but the existing traits are showing up twice.

Reproduction

Trampling charge is showing up twice:

monster: Gorgon
traits+:
  - name: "Boss"
    desc: "As a Boss monster, this creature acts twice (action + bonus action) at Initiative 15 and 5, and performs a basic attack or movement at Initiative 10 and 0.  This creature still only receives one reaction per round."

Which Operating Systems are you using?

Obsidian Version Check

1.2.8

Fantasy Statblocks Version

3.6.5

Confirmation

Possible solution

No response

Darthfett commented 1 year ago

See attached image, shows that Trampling Charge is included twice:

Gorgon

sigrunixia commented 1 year ago

Traits are slated to get reworked because of this. Javalent goes on vacation tomorrow for a few days. So we'll suggest creating new code block monsters in the interim until we can nail down this traits issue.

Currently, implementing the fix for this would re-open #222, so we have some head butting of the code to do.:)

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Azurewren commented 1 year ago

This is still a problem, can it be reopened?

sigrunixia commented 1 year ago

This should be resolved in #249. Note, that PF2E Statblocks are still subject to traits issues for a different reason.