javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
341 stars 71 forks source link

🐞 5e.tools alignment imported incorrectly #335

Closed trdischat closed 6 months ago

trdischat commented 6 months ago

Check for existing bug reports before submitting.

Expected Behavior

5e.tools json files record "Chaotic Evil" alignment as "alignment": ["C","E"]. Fantasy Statblocks should import this as alignment: chaotic evil.

Current behaviour

Fantasy Statblocks incorrectly imports this as alignment: chaotic or evil.

Reproduction

Import any content from 5e.tools into Fantasy Statblocks using the Import 5e.tools Data function. Any standard alignment other than True Neutral will combine the two words with "or".

Which Operating Systems are you using?

Obsidian Version Check

1.5.3 and 1.4.13

Plugin Version

3.16.3

Confirmation

Possible solution

Line 436 of 5eToolsImport.ts joins the parts of the alignment with " or ". Should this change?

trdischat commented 6 months ago

Closed with #336.