javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
341 stars 71 forks source link

🐞 Dice Callback is always shown as property-name's innerText if Dice Roller plugin is not installed or disabled #347

Closed silentjames closed 4 months ago

silentjames commented 5 months ago

Check for existing bug reports before submitting.

Expected Behavior

Even if the property has dice callback added, it should be replaced with simple property value if Dice Roller is not installed or removed.

Current behaviour

Some of my statblock have lots of properties with dice callbacks inside, and use these properties and callbacks with Dice Roller plugin, obviously. But if the plugin is disabled or not installed, dice callback are shown as property name's innerText. Even the callback setting are hidden in "edit block" settings.

image

Reproduction

  1. Launch Obsidian Sandbox;
  2. Install Fantasy Statblock;
  3. Install Dice Roller;
  4. Create new statblock with a property and valid dice callback in it;
  5. Create new note and add the new statblock
  6. Go to Community plugins and disable Dice Roller

It also works if user doesn't have Dice Roller installed and imports the pre-made statblock that has dice callbacks.

Which Operating Systems are you using?

Obsidian Version Check

1.5.3 and 1.5.3

Plugin Version

3.18.1

Confirmation

Possible solution

No response

valentine195 commented 4 months ago

@silentjames Can you send me your layout file?

silentjames commented 4 months ago

@valentine195 I think you have already fixed this issue! A month or so ago, here was a Dice Roller related update. And now it works great.

valentine195 commented 4 months ago

Great, thanks :)