javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
341 stars 71 forks source link

fix(css): add consistency to css variables for statblocks #369

Closed natowb closed 4 months ago

natowb commented 4 months ago

Pull Request Description

after #366 was merged I noticed a few other discrepancies so decided to handle them as well.

Changes Proposed

Related Issues

N/A

Checklist

Screenshots (if applicable)

Property name use css variable changes

:root {
    --statblock-property-name-font-color: var(--dark0);
}
Before After
property-name-before property-name-after

Trait property name changes

:root {
    --statblock-property-name-font-color: var(--dark0);
}
Before After
property-name-after trait-property-after

Section heading css variable changes :root { --statblock-section-heading-font-color: var(--dark0); }

Before After
section-heading-before section-heading-after

Additional Notes

N/A

natowb commented 4 months ago

hey @valentine195 how would you feel with me adding a css variable that allow you to modify the font color of the table header. ie alongside --statblock-table-header-font-weight creating a --statblock-table-header-font-color so that the ability names can be changed.

didnt want to add that to this PR as its creating new variables.

valentine195 commented 4 months ago

Yeah, that's a good idea.

natowb commented 4 months ago

Yeah, that's a good idea.

ok cool, ill work on that on a separate branch won't be included with this PR