javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
339 stars 68 forks source link

🐞 Can't remove dice parsing regexs on custom sheet layouts #382

Closed DrakeDWhite closed 2 months ago

DrakeDWhite commented 3 months ago

Check for existing bug reports before submitting.

Expected Behavior

When I hit the delete on a particular entry in my "Advanced" section of a custom character sheet layout, and then click the blue check mark to save my changes, that particular dice parsing regex entry should be removed from the list when I re-open the sheet.

image

Current behaviour

You can click the trash can icon next to a particular entry, save your changes, close the settings, and re-open the sheet's advanced settings, and that entry will still be there.

Reproduction

  1. Go to the Fantasy Statblocks settings
  2. Click the pencil next to a custom character sheet layout to begin editing
  3. Click "advanced" on the left side
  4. Click the trash can icon next to one of the entries and watch it disappear from the list
  5. Click the checkmark on the left side to save changes and close that sheet layout
  6. re-open that sheet layout and go to advanced settings, see that the entry you deleted is still there

Which Operating Systems are you using?

Obsidian Version Check

Obsidian: v1.5.12 Installer: v1.4.16

Plugin Version

4.0.9

Confirmation

Possible solution

No response