javalent / fantasy-statblocks

Create Dungeons and Dragons style statblocks for Obsidian.md
MIT License
346 stars 72 forks source link

Add support for PF2eMonsterTool import #437

Closed jayden-hunter closed 4 weeks ago

jayden-hunter commented 1 month ago

Pull Request Description

This Pull Request adds an import option for PF2eMonsterTool, which can be found here.

Changes Proposed

The main changes are as follows:

Related Issues

No related issues. Can create one if necessary.

Checklist

Screenshots (if applicable)

image

Additional Notes

This Plugin has been so useful to me, thank you very kindly for all of the work you've done on it!

BEGIN_COMMIT_OVERRIDE feat: Adds support for importing from PF2eMonsterTool END_COMMIT_OVERRIDE

miscoined commented 1 month ago

Just in case it's worth mentioning - if #438 gets merged in, that layout would probably be easier to import into without as much data wrangling.

This is great by the way, nice work :)

valentine195 commented 1 month ago

I will try to review this within the next week.

As an aside, this PR made me start thinking about creating a base importer class, to make it easier to PR new ones onto. I also want to rework the settings UI, it is getting quite cluttered.

jayden-hunter commented 1 month ago

Just in case it's worth mentioning - if #438 gets merged in, that layout would probably be easier to import into without as much data wrangling.

If it does, I'll be happy to update the importer :)

jayden-hunter commented 1 month ago

Just made a couple changes to the logic, clearly I hadn't tested extensively enough. Should be working now, sorry. Presuming there'll be some other things I'll have missed too, but happy to fix anything if I've screwed it up 👍