Closed Metevier closed 4 months ago
Thanks for the PR. I think I want to rework the whole Creature system, ultimately - it grew quite organically and is bit of a mess - but this PR looks good at first glance. I will try to review it in the next few days.
Pull Request Description
Creatures defined with statblocks inside notes now render correctly in Combatant. Previously, if there was a creature defined with the same name as one in the bestiary, it would override some stats correctly, but not all of them. A custom creature in a note also only rendered the 'initiative tracked' values. This probably need a more thorough testing, but everything seems to be working correctly from my tests.
Something this does not resolve, is if you reload obsidian while a custom creature is still in the initiative tracker, it will not rehydrate from the note.
Changes Proposed
Pass the original creature to the render plugin instead of the 'initiative tracked' creature
Related Issues
I think this is related to #193 #javalent/fantasy-statblocks/issues/401
Checklist
Screenshots (if applicable)
Before
After
BEGIN_COMMIT_OVERRIDE fix: Creatures not in bestiary now render correctly in Combatant END_COMMIT_OVERRIDE