🐞 Reapplying conditions remove them

[SondreElg]

Check for existing bug reports before submitting.

• [X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior

• add Blinded to Goblin 1 from an effect
• Goblin 1 and Goblin 2 are hit by Color Spray and will both be Blinded
• Blinded is added to Goblin 2 and no changes are made to Goblin 1

Current behaviour

• add Blinded to Goblin 1 from an effect
• Goblin 1 and Goblin 2 are hit by Color Spray and will both be Blinded
• Blinded is added to Goblin 2 as expected
• X Blinded is removed from Goblin 1

Reproduction

• Create an encounter with a monster
• Add a condition to the monster
• (condition is applied)
• Add the same condition to the monster again
• (condition is removed)

Which Operating Systems are you using?

• [ ] Android
• [ ] iPhone/iPad
• [X] Linux
• [ ] macOS
• [X] Windows

Obsidian Version Check

1.6.7 and 1.7.0

Plugin Version

13.0.12

Confirmation

• [X] I have disabled all other plugins and the issue still persists.

Possible solution

The current behaviour is technically intended, as it's hardcoded into src/tracker/stores/tracker.ts with corresponding logging behaviour. It is, however, confusing and a vestige from before we could remove conditions by crossing them out in the tracker itself.

Changing the behaviour would require rewriting most of the code in tracker.ts dealing with statuses.

[Trantion897]

I'd just like to mention I've been working on a change that has similar effects, but haven't made a PR yet. My change displays the status values (in Pathfinder some statuses have a numeric value) on the player view, which meant I needed to do basically the same change you've done to distinguish between changing a status value or removing the status. I'll take a look at this change to try to minimise the chance of a merge conflict