javalent / markdown-attributes

Add attributes to elements in Obsidian
MIT License
93 stars 6 forks source link

🐞 Performance impact on dataview #30

Open ItsFullOfCode opened 1 year ago

ItsFullOfCode commented 1 year ago

Check for existing bug reports before submitting.

Expected Behavior

markdown-attributres plugin should not have side effects on dataview's rendering performance.

Current behaviour

Rendering any dataview table with dv.view() had recently become quite slow on my Obsidian Windows installation. A couple of tables with slightly over 70 results took over 30 seconds to load.

The Performance profile indicated that the recent dataview performance hit might be related to the installation of the Markdown Attributes plugin. Once I disabled this plugin, dataview rendering became again near instantenous. Below a screenshot of the performance profile.

gnAU6Hktlk

Reproduction

Which Operating Systems are you using?

Obsidian Version Check

1.4.13, 1.4.13

Plugin Version

1.2.2

Confirmation

Possible solution

No response

EvanEdwards commented 1 year ago

I can confirm this. Tasks (which uses Dataview) has a similar slowdown. There's some kind of interaction that appears to be causing the issue. I have not dug in (for reasons stated below).

I am commenting to both confirm this bug and to point out that Dataview is nearing the end of a complete rewrite and rearchitecture that may address the issue.