fix: clean up settings - Githubissues

javalent / obsidian-leaflet

Adds interactive maps to Obsidian.md using Leaflet.js

481 stars 29 forks source link

fix: clean up settings #381

Closed Sirs0ri closed 1 year ago

Sirs0ri commented 1 year ago

functional fixes (via the change in src/utils/utils.ts)

markername / iconname inputs no longer disappear when empty
markername / iconname inputs now show errors correctly

visual fixes (via the changes in src/modals/settings.ts / main.css):

remove 2px "double borders" between some settings
remove unnecessary borders at the top/bottom of "create/edit marker" dialog
show big preview of images used as markers

sigrunixia commented 1 year ago

Would this close any existing issues, @Sirs0ri?

Sirs0ri commented 1 year ago

@sigrunixia nope

I thought about opening one for the disappearing markername/iconname fields in the settings ui, but then realised it would be faster to directly submit a PR with the fix.

if you want me to open an issue first I'm happy to do that!

sigrunixia commented 1 year ago

@sigrunixia nope

I thought about opening one for the disappearing markername/iconname fields in the settings ui, but then realised it would be faster to directly submit a PR with the fix.

if you want me to open an issue first I'm happy to do that!

Oh no worries! It's nice to have issues beforehand, or close tags in the description, but I was double checking for our project board. :)