javalent / obsidian-leaflet

Adds interactive maps to Obsidian.md using Leaflet.js
499 stars 30 forks source link

🐞 Custom svg icons for markers not functioning like default icons #419

Open Eldresh opened 1 year ago

Eldresh commented 1 year ago

Check for existing bug reports before submitting.

Expected Behavior

Custom uploaded svg icons should behave the same way icons included by default do, especially when the uploaded svg is also a FontAwesome icon, just not one of the ones included in the plugin.

Current behaviour

Currently, when someone uploads a custom image to use for a marker (displayed here with the SVG tree-city from FontAwesome, which is not included in Leaflet's version of FontAwesome) the ability to layer it on top of the base icon or to override the default icon color vanishes.

Additionally, when uploading an SVG file, it only seems to display part of the SVG and not the entire thing.

image

image

Reproduction

  1. Launch Obsidian (confirmed this reproduces in sandbox mode as well)
  2. Install Obsidian Leaflet
  3. Open the options menu
  4. Navigate to Obsidian Leaflet's options
  5. Open the dialogue to add an additional map marker
  6. Upload an SVG (example linked under "current behavior")

Which Operating Systems are you using?

Obsidian Version Check

1.3.7

Plugin Version

5.7.3

Confirmation

Possible solution

No response

Valombreuse commented 3 months ago

I had the same prob and reported it a while back. It comes in fact from the custom svg files that are not made correctly. the Dev can't make anything about it.