search

javalin / javalin-openapi

Annotation processor for compile-time OpenAPI & JsonSchema, with out-of-the-box support for Javalin 5.x, Swagger & ReDoc
https://github.com/javalin/javalin-openapi/wiki
Apache License 2.0
45 stars 17 forks source link

GH-151 Support auto-generated operationIds #152

Closed sauterl closed 1 year ago

dzikoysk commented 1 year ago

Thanks for PR, would you prefer a regular code review or should I just push changes to your branch?

sauterl commented 1 year ago

Thanks for PR, would you prefer a regular code review or should I just push changes to your branch?

I regular code review should do the trick - also for potential future contributions. However as written in the issue, the code lacks a proper (unit) test, since a) I didn't have the time for it and b) couldn't find your setup for testing that quickly.

dzikoysk commented 1 year ago

Thanks :) Because you don't have much time, I just covered it with test on my own. This change should be already available in the latest snapshot and it'll be also officially available in the next general Javalin version.

sauterl commented 1 year ago

Oh wow, thank you that was super quick! We'll be using the latest snapshot and hopefully this won't be an issue anymore (and safes us a lot of client-side refactoring time).

Cheers!