javalin / javalin-rendering

Artifact/module for server-side template/markdown rendering in Javalin: https://javalin.io/plugins/rendering
Apache License 2.0
11 stars 7 forks source link

Upgrade to jte 3 and use maven plugin to generate test template classes #26

Closed casid closed 1 year ago

casid commented 1 year ago

This should resolve #22

casid commented 1 year ago

As expected, the Java 11 tests fail since jte 3 is compiled with Java 17.

@tipsy, @dzikoysk I don't like the extra complexity in the maven build script. Also, I had to disable the .kte tests, as it seems the maven kotlin compiler does not pickup generated test sources. At least I found no way to do that, but I'm not very experienced in Kotlin. Do you have an idea?

For sake of simplicity I would also be happy with just merging the first commit (version bump) and call it a day.

tipsy commented 1 year ago

As expected, the Java 11 tests fail since jte 3 is compiled with Java 17.

I can remove that soon :)

@tipsy, @dzikoysk I don't like the extra complexity in the maven build script. Also, I had to disable the .kte tests, as it seems the maven kotlin compiler does not pickup generated test sources. At least I found no way to do that, but I'm not very experienced in Kotlin. Do you have an idea? For sake of simplicity I would also be happy with just merging the first commit (version bump) and call it a day.

I don't have any strong feelings on this, I'll leave it up to @dzikoysk to make his case.

dzikoysk commented 1 year ago

These tests pass for me with following addition:

casid commented 1 year ago

Nice, thank you for the fix @dzikoysk

tipsy commented 1 year ago

I rebased this onto Java 17 now @casid, are you ready for review?

casid commented 1 year ago

Yes, I think this is ready :-)

tipsy commented 1 year ago

Looks great, thank you @casid !