search

javalin / javalin-ssl

Straightforward SSL Configuration for Javalin!
https://javalin.io/plugins/ssl-helpers
10 stars 1 forks source link

Kotlin refactor #118

Closed zugazagoitia closed 8 months ago

zugazagoitia commented 9 months ago

Closes #111

codecov[bot] commented 9 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (e679290) 92.57% compared to head (e4cd339) 92.20%.

Files Patch % Lines
.../main/kotlin/io/javalin/community/ssl/SSLConfig.kt 82.08% 2 Missing and 10 partials :warning:
.../main/kotlin/io/javalin/community/ssl/SSLPlugin.kt 92.59% 1 Missing and 1 partial :warning:
...n/kotlin/io/javalin/community/ssl/util/SSLUtils.kt 91.66% 0 Missing and 2 partials :warning:
.../main/kotlin/io/javalin/community/ssl/TLSConfig.kt 97.91% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #118 +/- ## ============================================ - Coverage 92.57% 92.20% -0.38% + Complexity 77 73 -4 ============================================ Files 7 7 Lines 283 218 -65 Branches 20 24 +4 ============================================ - Hits 262 201 -61 + Misses 19 4 -15 - Partials 2 13 +11 ``` | [Flag](https://app.codecov.io/gh/javalin/javalin-ssl/pull/118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=javalin) | Coverage Δ | | |---|---|---| | [integrationTests](https://app.codecov.io/gh/javalin/javalin-ssl/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=javalin) | `?` | | | [unitTests](https://app.codecov.io/gh/javalin/javalin-ssl/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=javalin) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=javalin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.